OpenBSD 5.5 Released

2014-05-01 Thread Philip Guenther
, Matthias Kilian, Matthieu Herrb, Michael Erdely, Mike Belopuhov, Mike Larkin, Miod Vallat, Naoya Kaneko, Nayden Markatchev, Nicholas Marriott, Nick Holland, Nigel Taylor, Okan Demirmen, Otto Moerbeek, Pascal Stumpf, Paul de Weerd, Paul Irofti, Peter Hessler, Peter Valchev, Philip

Re: [RFC] Ai_ADDRCONFIG^WAIAIAIAIAIAIAEEEEEEEEE tweaks?

2014-05-02 Thread Philip Guenther
On Fri, May 2, 2014 at 1:14 PM, Kenneth Westerback kwesterb...@gmail.comwrote: -inet6 as the default seems more OpenBSD'ish to me. Everything off that can be off, but not more. That is not off which can eternal lie, And with strange aeons even inet4 may die.

Re: malloc in libssl/src/apps

2014-05-04 Thread Philip Guenther
: a) the existing code's lack of memset/bzero is a bug (details?), OR b) using calloc() instead of reallocarray() is *wrong*. Philip Guenther

Re: malloc in libssl/src/apps

2014-05-04 Thread Philip Guenther
On Sunday, May 4, 2014, patrick keshishian sids...@boxsoft.com wrote: On Sun, May 04, 2014 at 12:29:59AM -0700, Philip Guenther wrote: On Sun, May 4, 2014 at 12:21 AM, patrick keshishian sids...@boxsoft.comjavascript:; wrote: On Sun, May 04, 2014 at 02:38:40AM -0400, Jean-Philippe

Re: Fix the mtime for file creation on ext2+

2014-05-06 Thread Philip Guenther
On Tue, 6 May 2014, Vadim Zhukov wrote: This fixes a bug with mtime not updated after file creation on ext2+ file systems. Try it yourself: # mount -t ext2fs /dev/sd0o /mnt # cp /tmp/qq /mnt # ls -l /mnt/qq -rw-r--r-- 1 root wheel 10 Jan 1 1970 qq # touch /mnt/qq -rw-r--r-- 1

Re: Remove ln -F

2014-05-06 Thread Philip Guenther
On Tue, May 6, 2014 at 9:18 AM, Kenneth Westerback kwesterb...@gmail.comwrote: On 6 May 2014 11:45, Ingo Schwarze schwa...@usta.de wrote: Hi, if somebody wants to commit, ok schwarze@. Otherwise, i'm accepting OKs. See inline for a note on the history. Yours, Ingo Makes

Re: [PATCH] Speedstep bug

2014-05-10 Thread Philip Guenther
== high == 800 cpuspeed == 798 (!) Thanks for the report! kettenis@ noted that there's no point in enabling speedstep if there nothing to range over, so I've committed a slightly different diff to do that instead. Philip Guenther

Re: recvmsg, fd passing and soreceive

2014-05-14 Thread Philip Guenther
On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas j...@wxcvbn.orgwrote: ... So here's the diff I came up with: - set MSG_TRUNC for atomic protocols only if there is actually a data loss - drop the remaining mbuf(s) if the protocol is atomic *or* it is an empty message I'm

Re: recvmsg, fd passing and soreceive

2014-05-14 Thread Philip Guenther
On Wed, May 14, 2014 at 10:02 PM, Philip Guenther guent...@gmail.comwrote: On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas j...@wxcvbn.orgwrote: ... So here's the diff I came up with: - set MSG_TRUNC for atomic protocols only if there is actually a data loss - drop

Re: rsh vs net/ipcad - problems on 5.5

2014-05-20 Thread Philip Guenther
by the other side (POLLHUP). Does ipcad implement the expected ordering in the rsh protocol? Philip Guenther

Re: [PATCH 2] followup Speedstep bug

2014-05-22 Thread Philip Guenther
(with additional warning comment). Thanks. Philip Guenther

Re: [PATCH 2] libssl: malloc/memset = calloc

2014-05-25 Thread Philip Guenther
(STORE_OBJECT *) calloc(1, sizeof(STORE_OBJECT)); } Just say no to casting the return value of malloc/calloc/realloc! Philip Guenther

Re: remove appletalk from netintro(4)

2014-05-30 Thread Philip Guenther
On Thu, May 29, 2014 at 11:35 PM, Remi Locherer remi.loche...@relo.ch wrote: Support for Appeltalk (sys/netatalk) was removed about 3 years ago but netintro(4) still mentions it. Zapped. Thanks! Philip Guenther

Re: 9p

2014-05-31 Thread Philip Guenther
will help. You haven't found the real problem yet. Philip Guenther

Re: Remove unneeded patch to alias 646 = ascii in Encode::Alias

2014-05-31 Thread Philip Guenther
On Sat, May 31, 2014 at 10:22 AM, Andrew Fresh afre...@openbsd.org wrote: Turns out in 2008 the regex that aliases ISO-646 to ascii was changed so that it also matches plain 646, so we no longer need a patch to do that. Makes sense. ok guenther@ The secondary quotes on the definition

Re: [PATCH 4/7] use BIO_write instead of an unchecked write()

2014-06-01 Thread Philip Guenther
. Philip Guenther

Re: [PATCH 7/7] avoid defining struct pqueue typedef twice

2014-06-01 Thread Philip Guenther
for someone else to use the typedef. (Side note: a #define like HAVE_STRUCT_PQUEUE not only falls in the application namespace, but in the namespace that autohell squats on, make it a bad choice for anything not related to autohell.) Philip Guenther Index: dtls1.h

Re: LibreSSL memory leak fix

2014-06-03 Thread Philip Guenther
On Tue, Jun 3, 2014 at 2:56 PM, deoxyt2 deox...@lacamaradegas.cl wrote: I think that is: #include cryptlib.h and not #include cryptlib.h No. cryptlib.h isn't installed under /usr/include Philip Guenther

Re: 9p

2014-06-03 Thread Philip Guenther
no further until the copyright and license situation on this is believably resolved, as it's a waste of time if that can't happen. Philip Guenther

Re: 9p

2014-06-04 Thread Philip Guenther
On Wed, Jun 4, 2014 at 4:19 PM, M Farkas-Dyck strake...@gmail.com wrote: Matthew Dempsky matt...@dempsky.org wrote: Also, look at man 9 style; in particular, OpenBSD doesn't put spaces around - Not in cited document, but noted. Read more of the existing kernel code. Oh, and no static

Re: 9p

2014-06-04 Thread Philip Guenther
On Wed, 4 Jun 2014, Philip Guenther wrote: On Wed, Jun 4, 2014 at 4:19 PM, M Farkas-Dyck strake...@gmail.com wrote: Matthew Dempsky matt...@dempsky.org wrote: Also, look at man 9 style; in particular, OpenBSD doesn't put spaces around - Not in cited document, but noted. Read more

procfs to die [was: CVS: cvs.openbsd.org: src]

2014-06-22 Thread Philip Guenther
it... Philip Guenther -- Forwarded message -- From: Philip Guenther guent...@cvs.openbsd.org Date: Sun, Jun 22, 2014 at 2:15 PM Subject: CVS: cvs.openbsd.org: src To: source-chan...@cvs.openbsd.org CVSROOT:/cvs Module name:src Changes by: guent...@cvs.openbsd.org2014

Re: Turbo on i7

2014-06-22 Thread Philip Guenther
means it should/must run at 100%. I want to alert you to the fact that your message didn't include the system dmesg, and will therefore be ignored as insufficient data for analysis. Indeed, *NO ONE* has sent in a dmesg to dm...@openbsd.org for that CPU. Clearly it doesn't exist... Philip

Re: Patch: correct sysctl parameter in /sbin/route

2014-06-22 Thread Philip Guenther
. Is this intentional or should I write another patch correcting that? That's a bug, yes. Philip Guenther

Re: diff: Fix udp_usrreq.c to compile without IPSEC.

2014-06-23 Thread Philip Guenther
On Sun, Jun 22, 2014 at 11:47 PM, Jérémie Courrèges-Anglas j...@wxcvbn.org wrote: YASUOKA Masahiko yasu...@yasuoka.net writes: ok? ok

Re: diff: Fix udp_usrreq.c to compile without IPSEC.

2014-06-23 Thread Philip Guenther
. People messing with changing kernel options are wasting their own time; when they post to the list about it they waste EVERYONE'S time. To Mr Solonin: go read http://www.openbsd.org/faq/faq5.html#Why and then just use a GENERIC kernel and concentrate on getting useful work done. Philip

Re: diff: Fix udp_usrreq.c to compile without IPSEC.

2014-06-23 Thread Philip Guenther
On Mon, Jun 23, 2014 at 10:14 PM, YASUOKA Masahiko yasu...@yasuoka.net wrote: On Mon, 23 Jun 2014 16:33:46 -0700 Philip Guenther guent...@gmail.com wrote: ... Messing with kernel options #ifdefs without testing by building a release is unwise. People messing with changing kernel options

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-06-24 Thread Philip Guenther
'@'. The correct method to include an '@' in the userinfo part is to percent-encode it as %40. Philip Guenther

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-06-25 Thread Philip Guenther
On Wed, 25 Jun 2014, S?bastien Marie wrote: On Tue, Jun 24, 2014 at 10:55:44AM -0700, Philip Guenther wrote: On Tue, Jun 24, 2014 at 9:01 AM, S?bastien Marie semarie-open...@latrappe.fr wrote: ... Sorry, the patch is incorrect; per RFC 3986, the parser is correct to split the authority

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-06-29 Thread Philip Guenther
On Thu, 26 Jun 2014, S?bastien Marie wrote: On Wed, Jun 25, 2014 at 07:07:30PM -0700, Philip Guenther wrote: On Wed, 25 Jun 2014, S?bastien Marie wrote: On Tue, Jun 24, 2014 at 10:55:44AM -0700, Philip Guenther wrote: On Tue, Jun 24, 2014 at 9:01 AM, S?bastien Marie semarie-open

Re: [PATCH] rdist: malloc/memset = calloc

2014-07-04 Thread Philip Guenther
Slightly tweaked version applied. Thanks Philip Guenther

Re: [PATCH] rtadvd malloc/memset = calloc

2014-07-04 Thread Philip Guenther
rtadvd, rtsold, and sasyncd diffs applied. Thanks! Philip Guenther

Re: PATCH: ftp: allow @ in username for Basic Auth

2014-07-05 Thread Philip Guenther
On Tue, Jul 1, 2014 at 7:09 AM, Sébastien Marie semarie-open...@latrappe.fr wrote: On Sun, Jun 29, 2014 at 09:52:28PM -0700, Philip Guenther wrote: Here's a patch to do that. Just a comment in code (unused variables in urldecode). Else it seems ok. And my use-case works. Dang

Re: Mark get*[ug]id() as NOLOCK

2014-07-07 Thread Philip Guenther
On Mon, Jul 7, 2014 at 11:18 AM, Matthew Dempsky matt...@dempsky.org wrote: Recently guenther changed user credentials to be a per-process resource, but kept a per-thread cache of credentials that get refreshed at each system call entry. All of the get*[ug]id() system calls simply access the

Re: Use atomics for mutating p_sigmask

2014-07-08 Thread Philip Guenther
at this because it's a tall pole in syscall counts because of ld.so..but I'm working to drop it from the top 20 syscalls as a side-effect of adding __kbind() Philip Guenther

Re: PATCH: misc mkstemp and fdopen fixes

2014-07-11 Thread Philip Guenther
); err(1, fdopen); + } This and several other need to save errno and use errc(), ala: if ( (edit_file = fdopen(fd, w+)) == 0) { int saved_errno = errno; unlink(edit_name); close(fd); errc(1, saved_errno, fdopen); } Philip Guenther

Re: [PATCH] main symbol in libcrypto causes trouble

2014-07-12 Thread Philip Guenther
in the library that the linker resolves to the executable's. So, before just ripping it out (it's there for a reason), let's get enough info to understand why it's causing compilation problems (that's a pretty generic description...) Philip Guenther

Re: Changing a running process' cmd name/argv[0]

2014-07-14 Thread Philip Guenther
doing this and the reason is X runs my lib or a program that runs my lib and thus gets fork, which it can't handle. I think this is because it has the same command name (probably not.) Thus gets fork? What does that mean? What is the actual error that occurs? Philip Guenther

Re: Changing a running process' cmd name/argv[0]

2014-07-15 Thread Philip Guenther
On Mon, Jul 14, 2014 at 1:52 PM, Gustav Fransson Nyvell gus...@nyvell.se wrote: On 07/14/14 09:42, Philip Guenther wrote: On Mon, Jul 14, 2014 at 4:25 AM, Gustav Fransson Nyvell gus...@nyvell.se wrote: I'm looking at 5.5-current. I'm forking inside a lib and I want to change the forks

Re: Refactor dopselect() and doppoll()

2014-07-15 Thread Philip Guenther
a bit further, but having this diff in place should make them easier to review. ok? Makes sense to me, though I would use a do {} while (error==0); loop instead of for(;;){... if (error) break;} Philip Guenther

Re: Changing a running process' cmd name/argv[0]

2014-07-15 Thread Philip Guenther
On Tue, Jul 15, 2014 at 6:20 AM, Gustav Fransson Nyvell gus...@nyvell.se wrote: On 07/15/14 11:13, Peter Hessler wrote: On 2014 Jul 15 (Tue) at 10:25:49 +0200 (+0200), Gustav Fransson Nyvell wrote: :On 07/15/14 09:48, Philip Guenther wrote: :When the process that's executing your .xinitrc

Re: Changing a running process' cmd name/argv[0]

2014-07-16 Thread Philip Guenther
On Wed, Jul 16, 2014 at 2:53 AM, Gustav Fransson Nyvell gus...@nyvell.se wrote: On 07/15/14 23:55, Philip Guenther wrote: On Tue, Jul 15, 2014 at 6:20 AM, Gustav Fransson Nyvell gus...@nyvell.se wrote: On 07/15/14 11:13, Peter Hessler wrote: On 2014 Jul 15 (Tue) at 10:25:49 +0200

Re: Changing a running process' cmd name/argv[0]

2014-07-16 Thread Philip Guenther
On Wed, Jul 16, 2014 at 3:45 AM, Gustav Fransson Nyvell gus...@nyvell.se wrote: On 07/16/14 10:31, Philip Guenther wrote: On Wed, Jul 16, 2014 at 2:53 AM, Gustav Fransson Nyvell gus...@nyvell.se wrote: On 07/15/14 23:55, Philip Guenther wrote: ... So let's try that question

Re: Changing a running process' cmd name/argv[0]

2014-07-16 Thread Philip Guenther
that! No wonder you don't have time to code. You know, you're right: I should have spent this time writing up my hackathon report. I hope you find a solution to your problem. Philip Guenther

Re: Miscellaneous LibreSSL portability fixes

2014-07-16 Thread Philip Guenther
in include/machine/endian.h is _COMPAT_BYTE_ORDER_H_ (in the reserved namespace) while the other headers use the macro LIBCRYPTOCOMPAT_FOO_H. Nice catch. Philip Guenther

Re: Probably you already know but http://www.openbsd.org/cgi-bin/cvsweb/ is returning HTTP 403 Forbidden

2014-07-16 Thread Philip Guenther
On Wed, Jul 16, 2014 at 11:01 PM, patrick keshishian pkesh...@gmail.com wrote: On 7/16/14, Bob Beck b...@obtuse.com wrote: I've disabled it due to persistant DOS attacks. It may come back later. wait ... what? you helping'em? :P In the times that you've come back from 15 hours of travel

Re: PATCH: avoid clobbering errno before err/warn

2014-07-19 Thread Philip Guenther
is called. It checked a list of functions that are typically used in error handling and may set errno: close, fclose, unlink, rmdir, fflush and kill. Nice job! Committed (except for the microcode/bwi file where your diff revealed another existing bug that we can fix at the same time...) Philip

Re: PATCH: regress/gnu/egcs/gcc-builtins/stpcpy

2014-07-19 Thread Philip Guenther
On Sat, Jul 19, 2014 at 2:36 PM, Doug Hogan d...@acyclic.org wrote: Strings changed in the warning message. Committed; thanks!

Re: PATCH: fix open_memstream's regression test

2014-07-19 Thread Philip Guenther
On Thu, Jul 17, 2014 at 7:27 PM, Doug Hogan d...@acyclic.org wrote: Ran into this while running the regression suite for another patch. The regression test for open_memstream causes a SIGBUS because it closes the stream too early. Replaced fclose with fflush since they both update pbuf and

Re: PATCH: avoid clobbering errno before err/warn

2014-07-19 Thread Philip Guenther
On Sat, Jul 19, 2014 at 6:57 PM, Doug Hogan d...@acyclic.org wrote: On Sat, Jul 19, 2014 at 06:40:54PM -0700, Philip Guenther wrote: Nice job! Committed (except for the microcode/bwi file where your diff revealed another existing bug that we can fix at the same time...) Thanks! Here's

Re: const static - static const

2014-07-19 Thread Philip Guenther
of the declaration specifiers in a declaration is an obsolescent feature. and -Wextra complains: warning: 'static' is not at beginning of declaration Yep; (revised) diff committed. Philip Guenther

Re: suspend-related shceduler fix

2014-07-26 Thread Philip Guenther
On Sat, Jul 26, 2014 at 4:56 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: Thanks to the evil Intel AMT serial, I've been able to figure out what made my x220 hang when suspending. Turns out that the fix matthew@ committed almost two weeks ago uncovered another bug that made

Re: [PATCH] libressl/apps: load trusted ca certificates as specified on the command line

2014-07-27 Thread Philip Guenther
be a better choice, but changing that behavior seems unwise. Philip Guenther

Re: [Patch] exec(3) Manual

2014-07-27 Thread Philip Guenther
in execvpe() doesn't follow the null pointer that terminates the list of arguments. Something more is needed to cover both. Philip Guenther

Re: [PATCH] libressl/apps: load trusted ca certificates as specified on the command line

2014-07-27 Thread Philip Guenther
will be available That is, it would move the default CA loading from the specified either or both option and nothing failed case to the specified neither option case. Yes? Philip Guenther

Re: string.h __POSIX_VISIBLE

2014-07-28 Thread Philip Guenther
which changed different conditions to the same condition; I missed that those two ended up the same. No semantic shurg I'll commit this after unlock... Philip Guenther

Re: [PATCH] libressl/apps: load trusted ca certificates as specified on the command line

2014-08-06 Thread Philip Guenther
what to do at that point. Of course, if the OpenSSL security release in checks watch 34 minutes touches this area Philip Guenther

Re: [patch] ldattach ignores -t for msts line discipline

2014-08-09 Thread Philip Guenther
On Thu, Aug 7, 2014 at 1:07 PM, Maurice Janssen maur...@z74.net wrote: The -t option for ldattach doesn't seem to work when using an msts time receiver. The patch below fixes this. I guess this part was forgotten when msts support was added in r1.4. Committed. Philip Guenther

Re: insque/remque bugs

2014-08-09 Thread Philip Guenther
in a header to define NULL), _do_ please follow up to your original email... ;-) Philip Guenther

Re: insque/remque bugs

2014-08-10 Thread Philip Guenther
On Sun, 10 Aug 2014, Miod Vallat wrote: If the queue is to be used as a linear list, invoking insque(element, NULL), where element is the initial element of the queue, shall initialize the forward and backward pointers of element to null pointers. Hmm. Do the vax ASM versions

Re: insque/remque bugs

2014-08-14 Thread Philip Guenther
On Sun, Aug 10, 2014 at 5:58 PM, Philip Guenther guent...@gmail.com wrote: ... So, complete diff. This also zaps the unnecessary casts in the .c files. This has been committed; thank for the patch. Philip Guenther

diff -w vs files that don't end in a newline

2014-08-15 Thread Philip Guenther
wrong: the -w option shouldn't break the output format. Philip Guenther

Re: [Patch] exec(3) Manual

2014-08-15 Thread Philip Guenther
On Wed, Jul 30, 2014 at 7:21 PM, Justus Baumgartner medde...@gmail.com wrote: On Sun, Jul 27, 2014 at 6:38 AM, Philip Guenther guent...@gmail.com wrote: ... That phrasing seems wrong: the environment pointer in execvpe() doesn't follow the null pointer that terminates the list

Re: /etc/rc nit

2014-08-17 Thread Philip Guenther
it does anything useful. Maybe the [ -f /sbin/ldconfig ] test should go away completely... Philip Guenther

Re: Paravirtualized optimizations for KVM

2014-08-17 Thread Philip Guenther
On Wed, Jul 9, 2014 at 12:26 PM, Stefan Fritsch s...@sfritsch.de wrote: On Tuesday 08 July 2014 23:53:21, Mark Kettenis wrote: ... If we're serious about supporting OpenBSD on (KVM) hypervisors, something like this makes sense. We tend to try and have a single kernel that runs on the

Re: [Patch] exec(3) ERRORS

2014-08-17 Thread Philip Guenther
On Sun, Aug 17, 2014 at 9:36 PM, Justus Baumgartner medde...@gmail.com wrote: Add mention of execvpe() setting errno on failure. Ooops, yep. Committed, thanks! Philip Guenther

Re: /dev/crypto removal (3bis): DTYPE_CRYPTO

2014-08-19 Thread Philip Guenther
On Mon, Aug 18, 2014 at 8:02 AM, Mike Belopuhov m...@belopuhov.com wrote: I don't know if we recycle them somehow, but just in case... --- sys/sys/file.h +++ sys/sys/file.h ... -#defineDTYPE_CRYPTO5 /* crypto */ +/* was define DTYPE_CRYPTO5 */ When it goes, this

Re: diff -w vs files that don't end in a newline

2014-08-25 Thread Philip Guenther
On Mon, Aug 25, 2014 at 2:01 PM, Kent R. Spillner kspill...@acm.org wrote: ... Here's an updated diff. This adds a new testcase covering the situation when b has fewer lines than a (the minus sign also appeared in the wrong location). Ok? Looks good to me. Thanks! ok guenther@

Re: changing ffs mount between rw and ro while preserving softdep

2014-08-27 Thread Philip Guenther
On Wed, Aug 27, 2014 at 11:50 AM, Miod Vallat m...@online.fr wrote: Why not keep the softdep flag when updating rw-ro? E.g. via mount -ur /usr/obj fstab(5) already allows ro+softdep. Because if we were to apply this diff, there would be no way to switch from rw+softdep to rw. And what

Re: Make procfs root listing work again

2014-08-27 Thread Philip Guenther
On Wed, Aug 20, 2014 at 5:23 AM, Visa Hankala v...@hankala.org wrote: On Tue, Aug 19, 2014 at 10:14:59PM -0700, Philip Guenther wrote: Can you describe what you're using that needs it? Well, I am not using it. The code has not been sent to the Attic yet and I happened to take a look

Re: minphys woes

2014-09-02 Thread Philip Guenther
for, no? Not quite what I hoped, but ok. Do you know a good place where this should be documented? minphys is currently documented on physio(9) Philip Guenther

Re: minphys woes

2014-09-02 Thread Philip Guenther
On Tue, Sep 2, 2014 at 2:07 PM, Stefan Fritsch s...@sfritsch.de wrote: On Tuesday 02 September 2014 13:15:19, Philip Guenther wrote: On Tue, Sep 2, 2014 at 12:51 PM, Stefan Fritsch s...@sfritsch.de wrote: On Monday 01 September 2014 22:24:16, David Gwynne wrote: i haven't found

Re: minphys woes

2014-09-03 Thread Philip Guenther
On Wed, Sep 3, 2014 at 10:51 AM, Stefan Fritsch s...@sfritsch.de wrote: On Tuesday 02 September 2014 15:22:16, Philip Guenther wrote: From physio(9): minphys A device specific routine called to determine the maximum transfer size that the device's strategy routine can

Re: patch: fsck_ffs(8): fix false errors on very long files

2014-09-05 Thread Philip Guenther
was used in the check, resulting the ALLOCATED FRAG # MARKED FREE warning never being shown! This was happy on a clean filesystem (I haven't intentionally corrupted a filesystem for testing) and I've installed this on my laptop. oks? Philip Guenther Index: dir.c

Re: patch: fsck_ffs(8): fix false errors on very long files

2014-09-05 Thread Philip Guenther
On Fri, Sep 5, 2014 at 3:54 PM, David Vasek va...@fido.cz wrote: On Fri, 5 Sep 2014, Philip Guenther wrote: While di_blocks is unsigned, daddr_t is signed so we cast and print blocks as long long's. Noted, thanks. quad_t id_filesize; /* for DATA nodes, the size of the directory

Re: Marking CIRCLEQ_* macros as deprecated in queue(3)

2014-09-12 Thread Philip Guenther
On Mon, 8 Sep 2014, Jona Joachim wrote: On 2014-09-06, Gr?goire Duch?ne gduch...@awhk.org wrote: Hi, Although CIRCLEQ_* macros are deprecated, queue(3) does not say so. perhaps it would be interesting to mention why circle queues got deprecated. Let's go a step further and remove them

Re: Marking CIRCLEQ_* macros as deprecated in queue(3)

2014-09-12 Thread Philip Guenther
On Fri, 12 Sep 2014, Todd C. Miller wrote: No objection here. I'd go a step farther and nuke all the FOO_END macros as well. They add nothing and just make code harder to read. Better? Index: queue.3 === RCS file:

Re: sigaction.2 consistency

2014-09-15 Thread Philip Guenther
On Sun, Sep 14, 2014 at 9:33 PM, Jean-Philippe Ouellet jean-phili...@ouellet.biz wrote: We use async-signal-safe (not async-signal safe) elsewhere, and so does POSIX. Yep. Committed to there and signal(3). Thanks!

Re: Fix for POSIX conformance issue

2014-09-17 Thread Philip Guenther
about signal.h you're referring to there...) Philip Guenther

Re: pthread bug

2014-09-18 Thread Philip Guenther
On Thu, Sep 18, 2014 at 3:33 PM, Matti Karnaattu mkarnaa...@gmail.com wrote: This doesn't compile: It's broken code: PTHREAD_ONCE_INIT is only required to be an initializer, not a value. Philip Guenther

Re: Missing include in sys/ipc.h

2014-09-20 Thread Philip Guenther
. We've tried to do more minimal #including/exporting generally, but SysV IPC is enough of a corner that just pulling in sys/types.h from sys/ipc.h is fine by me. Philip Guenther

Re: Missing EOVERFLOW

2014-09-20 Thread Philip Guenther
On Sat, Sep 20, 2014 at 6:52 AM, Matti Karnaattu mkarnaa...@gmail.com wrote: Should you add EBADMSG and EPROTO too? IMO, it's a bug in POSIX that those weren't marked OB XSR. Note that adding errno defines requires a libc major bump.

Re: maketz.sh problems with distrib build

2014-09-27 Thread Philip Guenther
and assemble the release out of that? To absolutely guarantee that it cannot pick up a file left over in the running install from a previous version.) Philip Guenther

Re: maketz.sh problems with distrib build

2014-09-27 Thread Philip Guenther
the direct message. Philip Guenther

Re: [patch]lock and unlock like GnuRCS

2014-10-01 Thread Philip Guenther
POSIX and does not follow the POSIX utility argument guidelines multiple ways. Changing OpenRCS to follow those guidelines would make it incompatible with GNU RCS and the the deployed base of scripts...and fingers... Philip Guenther

Re: Enable DWARF line decoding in ddb

2014-10-02 Thread Philip Guenther
/boot /boot installboot -v /boot /usr/mdec/biosboot sd0 That should be installboot -v sd0 /usr/mdec/biosboot /boot (and if your boot drive isn't sd0 then change the line as appropriate, of course.) Philip Guenther

Re: replace select with nanosleep in libc/termios/tcsendbreak.c

2014-10-09 Thread Philip Guenther
On Wed, Oct 8, 2014 at 10:22 PM, David Gwynne da...@gwynne.id.au wrote: deraadt points out i suck at grep. ok? Sure. Even has the same semantics if a signal is received.

Re: syslogd: patch for CVE-2014-3634

2014-10-12 Thread Philip Guenther
on. Have you actually managed to make it crash? I've already committed a check for this when this first came out, mapping out of bounds pri values to LOG_USER, and at that time no one was able to crash the code without the check... Thoughts? Okays? Meh, seems like overkill. Philip Guenther

Re: improving OpenBSD's gmac.c...

2014-10-13 Thread Philip Guenther
after pulling in sys/types.h or sys/param.h, so it's just noise and wasted compiler cycles. The manpages for the kernel-only interfaces (bemtoh*, etc) should presumably follow that: recommending sys/types.h until someone removes the indirect #include. Philip Guenther

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Philip Guenther
and CLOCK_PROF, modeled after what FreeBSD does. out of curiousity, what program needs these? Possibly none, but we currently define CLOCK_VIRTUAL but don't actually support it. IMO we should just delete CLOCK_VIRTUAL from sys/_time.h and clock_gettime(2). Philip Guenther

Re: Replace LibreSSL times() call

2014-10-15 Thread Philip Guenther
and working and replace it with something non-standard or using more ifdefs? Umm, why? Maybe this is a good idea, but you let out all the here's why! part in your message. Philip Guenther

Re: rm: ignorance isn't bliss

2014-10-17 Thread Philip Guenther
: function rm { local rmopts arg for arg do case $arg in -*) set -A rmopts -- ${rmopts[@]} $arg;; *) command rm ${rmopts[@]} $arg || return;; esac done } Philip Guenther

Re: getent(1) hosts enumeration defunc

2014-10-18 Thread Philip Guenther
/etc/hosts? It's been removed from POSIX and I'm at loss to think of a use of it that wouldnt make further nonportable assumptions. Maybe we just fix getent(1) to return an error like it does for ethers? Philip Guenther

Re: getent(1) hosts enumeration defunc

2014-10-18 Thread Philip Guenther
On Sat, Oct 18, 2014 at 5:24 PM, Ingo Schwarze schwa...@usta.de wrote: Index: getent.c === RCS file: /cvs/src/usr.bin/getent/getent.c,v retrieving revision 1.6 diff -u -p -r1.6 getent.c --- getent.c30 Mar 2013 14:03:08 -

Re: Reading 56.html

2014-10-21 Thread Philip Guenther
. OpenBSD 5.6 was cut as a release a ways before that. Philip Guenther

Re: \c for printf(1)

2014-10-22 Thread Philip Guenther
in the man page so it fits into the otherwise alphabetical order of the escape sequences. This probably makes sense, though maybe \e is mis-sorted because it's an extension? Nah. Philip Guenther

Re: sed: allow d and y functions in { } function list

2014-10-22 Thread Philip Guenther
both of them. Or is there some reason this extension is required? Philip Guenther

Re: \c for printf(1)

2014-10-22 Thread Philip Guenther
On Wed, Oct 22, 2014 at 1:25 AM, Ingo Schwarze schwa...@usta.de wrote: OK? Ingo Looks good to me Philip

Re: Rdistd can dump core with cmdspecial

2014-11-08 Thread Philip Guenther
with the new command...) Philip Guenther

Re: is* functions

2013-07-06 Thread Philip Guenther
On Sat, Jul 6, 2013 at 12:29 AM, Jason McIntyre j...@kerhand.co.uk wrote: diff below from Daniel Dickman. it appears is* are functions, not macros (defined in gen/isctype.c). i'm looking for oks. Oh no! Someone found out that we changed them! We must hide the evidence! Uh, I mean, sure,

  1   2   3   4   5   6   7   8   9   10   >