Re: [Patch]openrcs: atoi to strtonum

2014-09-30 Thread Nicholas Marriott
ok nicm On Sat, Sep 27, 2014 at 05:07:58PM +0200, Otto Moerbeek wrote: On Fri, Sep 26, 2014 at 09:23:08PM +0200, Fritjof Bornebusch wrote: On Wed, Sep 24, 2014 at 10:31:17PM +0200, Otto Moerbeek wrote: Hi, On Wed, Sep 24, 2014 at 05:13:47PM +0200, Fritjof Bornebusch wrote:

Re: [Patch]openrcs: atoi to strtonum

2014-09-27 Thread Otto Moerbeek
On Fri, Sep 26, 2014 at 09:23:08PM +0200, Fritjof Bornebusch wrote: On Wed, Sep 24, 2014 at 10:31:17PM +0200, Otto Moerbeek wrote: Hi, On Wed, Sep 24, 2014 at 05:13:47PM +0200, Fritjof Bornebusch wrote: Hi, I changed atoi to strtonum in order to avoid overflows. One

Re: [Patch]openrcs: atoi to strtonum

2014-09-26 Thread Fritjof Bornebusch
On Wed, Sep 24, 2014 at 10:31:17PM +0200, Otto Moerbeek wrote: Hi, On Wed, Sep 24, 2014 at 05:13:47PM +0200, Fritjof Bornebusch wrote: Hi, I changed atoi to strtonum in order to avoid overflows. One concern: atoi() does not mind trailing stuff, while strtonum() does. Did you verify

[Patch]openrcs: atoi to strtonum

2014-09-24 Thread Fritjof Bornebusch
Hi, I changed atoi to strtonum in order to avoid overflows. fritjof Index: rcstime.c === RCS file: /cvs/src/usr.bin/rcs/rcstime.c,v retrieving revision 1.4 diff -u -p -r1.4 rcstime.c --- rcstime.c 29 Apr 2014 07:44:19 -

Re: [Patch]openrcs: atoi to strtonum

2014-09-24 Thread Otto Moerbeek
On Wed, Sep 24, 2014 at 05:13:47PM +0200, Fritjof Bornebusch wrote: Hi, I changed atoi to strtonum in order to avoid overflows. One concern: atoi() does not mind trailing stuff, while strtonum() does. Did you verify that the strings are just numbers in all cases? -Otto fritjof