Re: ospfd more ibuf cleanup

2023-07-03 Thread Theo Buehler
On Mon, Jul 03, 2023 at 11:28:44AM +0200, Claudio Jeker wrote: > Similar to the relayd diff use ibuf_data instead of ibuf->buf. ok tb

ospfd more ibuf cleanup

2023-07-03 Thread Claudio Jeker
Similar to the relayd diff use ibuf_data instead of ibuf->buf. -- :wq Claudio Index: auth.c === RCS file: /cvs/src/usr.sbin/ospfd/auth.c,v retrieving revision 1.21 diff -u -p -r1.21 auth.c --- auth.c 20 Jun 2023 15:19:55 -0

Re: ospfd use new ibuf functions

2023-06-20 Thread Theo Buehler
On Tue, Jun 20, 2023 at 06:29:59PM +0200, Claudio Jeker wrote: > On Tue, Jun 20, 2023 at 02:47:41PM +0200, Claudio Jeker wrote: > > This diff updates ospfd to use the new ibuf API. > > > > It mainly removes the use of ibuf_seek() and replaces these calls with > > i

Re: ospfd use new ibuf functions

2023-06-20 Thread Claudio Jeker
On Tue, Jun 20, 2023 at 02:47:41PM +0200, Claudio Jeker wrote: > This diff updates ospfd to use the new ibuf API. > > It mainly removes the use of ibuf_seek() and replaces these calls with > ibuf_set(). > > Regress still passes with this diff in. Here the same diff for ospf6

Re: ospfd use new ibuf functions

2023-06-20 Thread Claudio Jeker
On Tue, Jun 20, 2023 at 03:46:23PM +0200, Theo Buehler wrote: > On Tue, Jun 20, 2023 at 02:47:41PM +0200, Claudio Jeker wrote: > > This diff updates ospfd to use the new ibuf API. > > > > It mainly removes the use of ibuf_seek() and replaces these calls with > > ibuf_se

Re: ospfd use new ibuf functions

2023-06-20 Thread Theo Buehler
On Tue, Jun 20, 2023 at 02:47:41PM +0200, Claudio Jeker wrote: > This diff updates ospfd to use the new ibuf API. > > It mainly removes the use of ibuf_seek() and replaces these calls with > ibuf_set(). > > Regress still passes with this diff in. There's a functi

ospfd use new ibuf functions

2023-06-20 Thread Claudio Jeker
This diff updates ospfd to use the new ibuf API. It mainly removes the use of ibuf_seek() and replaces these calls with ibuf_set(). Regress still passes with this diff in. -- :wq Claudio Index: auth.c === RCS file: /cvs/src

Re: ospfd/ospf6d, interfaces in log messages

2021-11-03 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2021.11.03 22:23:44 +0100: > On Tue, Nov 02, 2021 at 05:27:11PM +, Stuart Henderson wrote: > > I've recently started seeing a number of flaps with ospfd/ospf6d > > with invalid seq nums / "seq num mismatch, bad flags" log

Re: ospfd/ospf6d, interfaces in log messages

2021-11-03 Thread Remi Locherer
On Tue, Nov 02, 2021 at 05:27:11PM +, Stuart Henderson wrote: > I've recently started seeing a number of flaps with ospfd/ospf6d > with invalid seq nums / "seq num mismatch, bad flags" logged. > Not quite sure what's going yet as they must be occurring on > va

ospfd/ospf6d, interfaces in log messages

2021-11-02 Thread Stuart Henderson
I've recently started seeing a number of flaps with ospfd/ospf6d with invalid seq nums / "seq num mismatch, bad flags" logged. Not quite sure what's going yet as they must be occurring on various local switched segments on one nic and also on ethernet wan circuits direct to

Re: ospfd seq out of order in ls_upd floods

2021-06-06 Thread Kapetanakis Giannis
On 05/06/2021 21:31, Stuart Henderson wrote: Sometimes I see authentication errors from ospfd, mainly (though possibly not entirely always) on a 30 minute cycle, e.g. these log entries 2021-06-03T05:30:04.952Z ospfd[31748]: spf_calc: area 0.0.0.0 calculated 2021-06-03T05:51:43.785Z ospfd

ospfd seq out of order in ls_upd floods

2021-06-05 Thread Stuart Henderson
Sometimes I see authentication errors from ospfd, mainly (though possibly not entirely always) on a 30 minute cycle, e.g. these log entries 2021-06-03T05:30:04.952Z ospfd[31748]: spf_calc: area 0.0.0.0 calculated 2021-06-03T05:51:43.785Z ospfd[76044]: auth_validate: decreasing seq num

ospfd -fno-common fixes

2021-01-18 Thread Claudio Jeker
This is my try at cleaning up commons in ospfd. I made one big combined diff but will probably split up a few things into own commits. E.g. the lsupdate.c and lsreq.c ones. I had to cleanup the control.c code a bit since this was a bit of a mess. While in bgpd I was able to remove the global

ospfd: use ROUTE_FLAGFILTER

2020-08-16 Thread Jonathan Matthew
ospfd is our first target for using ROUTE_FLAGFILTER to reduce pressure on the route socket, so here's the diff we've been running for a couple of weeks now (minus the fix for RTM_DELETE flags, notably). ok? Index: kroute.c =

Re: Prometheus core metrics for bgpd and ospfd approach ideas

2020-05-18 Thread Richard Chivers
Thanks for the comments, some good things to think about. Out of interest, can anyone think of some good examples of daemons which call ctl commands, just wanting to review the patterns and approach, and what is the best, best practice examples today. On Mon, 18 May 2020, 16:46 Theo de Raadt,

Re: Prometheus core metrics for bgpd and ospfd approach ideas

2020-05-18 Thread Theo de Raadt
Claudio Jeker wrote: > Last note, please do not try to directly talk to the daemons always pass > via the *ctl program. The API used between for example bgpd and bgpctl > is not public and also not stable. It requires that both tools are in > sync. There is an additional reason for doing this.

Re: Prometheus core metrics for bgpd and ospfd approach ideas

2020-05-18 Thread Claudio Jeker
On Mon, May 18, 2020 at 04:16:05PM +0100, Stuart Henderson wrote: > On 2020/05/18 15:31, Richard Chivers wrote: > > Hi, > > > > We could do with exposing certain metrics from bgpd, ospfd and pf. > > > > I was considering a couple of approaches and really was

Re: Prometheus core metrics for bgpd and ospfd approach ideas

2020-05-18 Thread Stuart Henderson
On 2020/05/18 15:31, Richard Chivers wrote: > Hi, > > We could do with exposing certain metrics from bgpd, ospfd and pf. > > I was considering a couple of approaches and really was just > interested in what would make most sense in general. > > Has anyone else considered

Prometheus core metrics for bgpd and ospfd approach ideas

2020-05-18 Thread Richard Chivers
Hi, We could do with exposing certain metrics from bgpd, ospfd and pf. I was considering a couple of approaches and really was just interested in what would make most sense in general. Has anyone else considered this at all? Would this be useful to anyone else? Also just to say I am not

that ospfd fix for ospf6d

2020-05-06 Thread Claudio Jeker
Can someone give this diff for ospf6d a try? This fixes the same issue that I just committed for ospfd: revision 1.48 date: 2020/05/06 14:40:54; author: claudio; state: Exp; lines: +5 -5; commitid: 1nh8JCAv0Kmqd1jV; Do not use the pointer returned by ibuf_reserve() after calling another ibuf

Re: ospf6d: bring ospf6d closer to ospfd

2020-03-28 Thread Denis Fondras
On Sat, Mar 28, 2020 at 05:00:11PM +0100, Remi Locherer wrote: > On Sat, Mar 21, 2020 at 05:25:45PM +0100, Denis Fondras wrote: > > Biggest chunk is rework of rde_asext_get()/rde_asext_put(). > > Also change get_net_link() and get_rtr_link() to work like ospfd couterpart. > >

Re: ospf6d: bring ospf6d closer to ospfd

2020-03-28 Thread Remi Locherer
On Sat, Mar 21, 2020 at 05:25:45PM +0100, Denis Fondras wrote: > Biggest chunk is rework of rde_asext_get()/rde_asext_put(). > Also change get_net_link() and get_rtr_link() to work like ospfd couterpart. Reads good to me and I didn't spot any issues running tests with it. One question

ospf6d: bring ospf6d closer to ospfd

2020-03-21 Thread Denis Fondras
Biggest chunk is rework of rde_asext_get()/rde_asext_put(). Also change get_net_link() and get_rtr_link() to work like ospfd couterpart. Index: rde.c === RCS file: /cvs/src/usr.sbin/ospf6d/rde.c,v retrieving revision 1.84 diff -u -p

Re: ospf6d: sync hello.c with ospfd

2020-01-03 Thread Remi Locherer
On Thu, Jan 02, 2020 at 05:17:02PM +0100, Denis Fondras wrote: > Sync with ospfd's hello.c ok remi@ > > Index: hello.c > === > RCS file: /cvs/src/usr.sbin/ospf6d/hello.c,v > retrieving revision 1.21 > diff -u -p -r1.21 hello.c > ---

Re: ospf6d: sync database.c with ospfd(8)

2020-01-03 Thread Remi Locherer
On Thu, Jan 02, 2020 at 04:05:45PM +0100, Denis Fondras wrote: > This is mostly log messages sync. ok remi@ > > Index: database.c > === > RCS file: /cvs/src/usr.sbin/ospf6d/database.c,v > retrieving revision 1.18 > diff -u -p -r1.18

ospf6d: sync hello.c with ospfd

2020-01-02 Thread Denis Fondras
Sync with ospfd's hello.c Index: hello.c === RCS file: /cvs/src/usr.sbin/ospf6d/hello.c,v retrieving revision 1.21 diff -u -p -r1.21 hello.c --- hello.c 23 Dec 2019 11:25:41 - 1.21 +++ hello.c 2 Jan 2020 16:11:19 -000

ospf6d: sync database.c with ospfd(8)

2020-01-02 Thread Denis Fondras
This is mostly log messages sync. Index: database.c === RCS file: /cvs/src/usr.sbin/ospf6d/database.c,v retrieving revision 1.18 diff -u -p -r1.18 database.c --- database.c 23 Dec 2019 07:33:49 - 1.18 +++ database.c 2 Jan 2

Re: ospfd: type p2p

2019-11-18 Thread Kapetanakis Giannis
On 17/11/2019 13:44, Remi Locherer wrote: > Yes, I'll send a separate diff for that later. > > OK for the new diff? Works for me. G

Re: ospfd: type p2p

2019-11-17 Thread Claudio Jeker
> > > > > fib > > > > > and routing table!) and also test reports with real p2p2 interfaces > > > > > (gif > > > > > or gre). > > > > > > > > > > Of course OKs are also welcome. ;-) > > > > > > > &

Re: ospfd: type p2p

2019-11-17 Thread Remi Locherer
ting table!) and also test reports with real p2p2 interfaces (gif > > > > or gre). > > > > > > > > Of course OKs are also welcome. ;-) > > > > > > > > Remi > > > > > > > > > Hi, > > > > > > From firs

Re: ospfd: type p2p

2019-11-15 Thread Claudio Jeker
gre). > > > > > > Of course OKs are also welcome. ;-) > > > > > > Remi > > > > > > Hi, > > > > From first test seems to work :) > > > > looking forward test it for IPv6 as well > > > > thanks > >

Re: ospfd: type p2p

2019-11-15 Thread Remi Locherer
orts with real p2p2 interfaces (gif > > or gre). > > > > Of course OKs are also welcome. ;-) > > > > Remi > > > Hi, > > From first test seems to work :) > > looking forward test it for IPv6 as well > > thanks > > Giannis Anyon

Re: ospfd: correct function name in error message

2019-11-09 Thread Theo de Raadt
Sebastian Benoit wrote: > > OK. Another option is to use __func__ which is always correct. > > Please definatly use __func__. With that ok benno too. I like __func__ where it makes sense, but often developers consider "i've shown an obscurely named function that i know" to be a solved problem,

Re: ospfd: correct function name in error message

2019-11-09 Thread Sebastian Benoit
> > RCS file: /cvs/src/usr.sbin/ospfd/kroute.c,v > > retrieving revision 1.112 > > diff -u -p -r1.112 kroute.c > > --- kroute.c28 Dec 2018 19:25:10 - 1.112 > > +++ kroute.c9 Nov 2019 14:11:03 - > > @@ -1501,7 +1501,7 @@ rtmsg_pr

Re: ospfd: correct function name in error message

2019-11-09 Thread Claudio Jeker
On Sat, Nov 09, 2019 at 03:27:31PM +0100, Denis Fondras wrote: > Fix function name in error message. > > Index: kroute.c > === > RCS file: /cvs/src/usr.sbin/ospfd/kroute.c,v > retrieving revision 1.112 > diff -

ospfd: correct function name in error message

2019-11-09 Thread Denis Fondras
Fix function name in error message. Index: kroute.c === RCS file: /cvs/src/usr.sbin/ospfd/kroute.c,v retrieving revision 1.112 diff -u -p -r1.112 kroute.c --- kroute.c28 Dec 2018 19:25:10 - 1.112 +++ kroute.c9 Nov

Re: ospfd: type p2p

2019-11-04 Thread Remi Locherer
On Mon, Nov 04, 2019 at 02:01:57PM +0200, Kapetanakis Giannis wrote: > On 25/10/2019 13:57, Remi Locherer wrote: > > Hi tech@, > > > > earlier this year I sent a diff that allowed to change an interface > > from broadcast to point-to-point. > > > > https://marc.info/?l=openbsd-tech&m=15613292320370

Re: ospfd: type p2p

2019-11-04 Thread Kapetanakis Giannis
(check the fib > and routing table!) and also test reports with real p2p2 interfaces (gif > or gre). > > Of course OKs are also welcome. ;-) > > Remi Hi, >From first test seems to work :) looking forward test it for IPv6 as well thanks Giannis > > > > Index:

ospfd: more explicit error message

2019-11-01 Thread Denis Fondras
Newer version after a comment by claudio@. Currently ospfd logs routing message type code instead of name. Make it more explicit. remi@ is OK but wonders if rtm_type_name() will be updated as needed. What do you think ? Denis Index: kroute.c

ospfd: more explicit error message

2019-11-01 Thread Denis Fondras
Currently ospfd logs routing message type code instead of name. Make it more explicit. remi@ is OK but wonders if rtm_type_name() will be updated as needed (that's why I also log the typecode) What do you think ? Denis Index: kro

ospfd: type p2p

2019-10-25 Thread Remi Locherer
;-) Remi Index: hello.c === RCS file: /cvs/src/usr.sbin/ospfd/hello.c,v retrieving revision 1.24 diff -u -p -r1.24 hello.c --- hello.c 12 Aug 2019 20:21:58 - 1.24 +++ hello.c 21 Sep 2019 22:06:17 - @@ -189,14 +189,13 @@ recv_hello(struct iface *iface, struct i

Re: ospfd: warn when a neighbor changes its ip address

2019-08-11 Thread Sebastian Benoit
emi > > > Index: hello.c > === > RCS file: /cvs/src/usr.sbin/ospfd/hello.c,v > retrieving revision 1.23 > diff -u -p -r1.23 hello.c > --- hello.c 15 Jul 2019 18:26:39 - 1.23 > +++ hello.c 11 Aug 2019 09:36:13

Re: ospfd: check dst addr for hello packets

2019-08-11 Thread Sebastian Benoit
reads ok Remi Locherer(remi.loche...@relo.ch) on 2019.08.11 11:21:36 +0200: > When ospfd receives a hello packet it takes the src IP address and updates > the address in its neighbor struct for the given router id unconditionally. > > In the case of broadcast interfaces this is n

ospfd: warn when a neighbor changes its ip address

2019-08-11 Thread Remi Locherer
I'd like to get a notification when a neighbor changes the src IP address for hello packets. Either it is a planned change or something bad happens in the network. OK? Remi Index: hello.c === RCS file: /cvs/src/usr.sbin/

ospfd: check dst addr for hello packets

2019-08-11 Thread Remi Locherer
When ospfd receives a hello packet it takes the src IP address and updates the address in its neighbor struct for the given router id unconditionally. In the case of broadcast interfaces this is not a problem: find_iface() checks that the src address is from the same subnet as the receiving

Re: ospfd: improve logging when sendig packets fail

2019-07-14 Thread Claudio Jeker
On Mon, Jul 15, 2019 at 07:32:18AM +0200, Remi Locherer wrote: > Hi, > > I'd like to improve ospfd's logging when sending a packet fails. > > I got a debug output from a ospfd user which contains "send packet: error > ...". > I guess ospfd failed to s

ospfd: improve logging when sendig packets fail

2019-07-14 Thread Remi Locherer
Hi, I'd like to improve ospfd's logging when sending a packet fails. I got a debug output from a ospfd user which contains "send packet: error ...". I guess ospfd failed to send an ls ack. With below diff applied it would be clear which packet could not be sent and to which

Re: ospfd: point-to-point on ethernet interfaces

2019-07-04 Thread Remi Locherer
ck route the BSD is announcing. Thank you for testing! Can you send me your ospfd.conf, the output from ospfd -dv and the output from tcpdump showing the ospf traffic? > On 24/06/2019 01:33, Remi Locherer wrote: > > Diff below adds to ospfd point to point support for Ethernet interfaces.

Re: ospfd: point-to-point on ethernet interfaces

2019-07-03 Thread Kapetanakis Giannis
Hi, This does not work for me with IOS. neighbor is full, rib is ok fib does not list the routes to IOS and routing table is not updated on BSD On IOS I do have the loopback route the BSD is announcing. G On 24/06/2019 01:33, Remi Locherer wrote: > Diff below adds to ospfd point to po

Re: ospfd: point-to-point on ethernet interfaces

2019-07-03 Thread Gregory Edigarov
Works for me no problem. tested to IOS. On 03.07.19 00:00, Remi Locherer wrote: ping On Mon, Jun 24, 2019 at 12:33:16AM +0200, Remi Locherer wrote: Diff below adds to ospfd point to point support for Ethernet interfaces. I successfully tested this against Junos and FastIron. I first made the

Re: ospfd: point-to-point on ethernet interfaces

2019-07-02 Thread Remi Locherer
ping On Mon, Jun 24, 2019 at 12:33:16AM +0200, Remi Locherer wrote: > Diff below adds to ospfd point to point support for Ethernet interfaces. > I successfully tested this against Junos and FastIron. > > I first made the key word in the config "point-to-point". But then I

ospfd: point-to-point on ethernet interfaces

2019-06-23 Thread Remi Locherer
Diff below adds to ospfd point to point support for Ethernet interfaces. I successfully tested this against Junos and FastIron. I first made the key word in the config "point-to-point". But then I changed to "type p2p". The later would allow for "type nbma" or &

Re: ospfd: allow specifying area by number as well as id

2019-06-06 Thread David Gwynne
cherer >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Hi David >>>>>>>>> >>>>>>>>> On Mon, Apr 29, 2019 at 11:53:27AM +1000, David Gwynne wrote: >>>>>>>>>

Re: ospfd: allow specifying area by number as well as id

2019-05-28 Thread Remi Locherer
gt; > >> a number, > > > > > > > >> but then have to think hard to convert that number to an > > > > > > > >> address for use > > > > > > > >> in openbsd. eg, i was given area 700 in one place, which is > &

Re: ospfd: allow specifying area by number as well as id

2019-05-16 Thread Remi Locherer
it's always bothered me that i config areas on a crisco using a > > > > > > >> number, > > > > > > >> but then have to think hard to convert that number to an address > > > > > > >> for use > > > > > >

Re: ospfd: allow specifying area by number as well as id

2019-05-16 Thread Sebastian Benoit
>> but then have to think hard to convert that number to an address > > > > > >> for use > > > > > >> in openbsd. eg, i was given area 700 in one place, which is > > > > > >> 0.0.2.188 > > > > > >> as

Re: ospfd: allow specifying area by number as well as id

2019-05-16 Thread Denis Fondras
On Wed, May 15, 2019 at 11:15:03PM +0200, Remi Locherer wrote: > Any opinions or comments on this? I think this would be a valuable addition > to ospfd. > I can't see any harm in it. OK denis@ > > > > Below diff changes ospfctl to accept the address and number f

Re: ospfd: allow specifying area by number as well as id

2019-05-15 Thread Remi Locherer
t; > >> it's always bothered me that i config areas on a crisco using a > > > > >> number, > > > > >> but then have to think hard to convert that number to an address for > > > > >> use > > > > >> in openbsd. eg, i

Re: ospfd: do not change router-id on reload if unspecified

2019-05-15 Thread Remi Locherer
On Wed, May 15, 2019 at 03:52:57PM +0200, Denis Fondras wrote: > When router-id is unspecified, ospfd will choose the lowest IP address of the > host. I added an area and an IP lower than the existing ones and on reload > ospfd asked me to restart and did not activate the new area. >

ospfd: do not change router-id on reload if unspecified

2019-05-15 Thread Denis Fondras
When router-id is unspecified, ospfd will choose the lowest IP address of the host. I added an area and an IP lower than the existing ones and on reload ospfd asked me to restart and did not activate the new area. Why would it update the router-id in such a case ? This diff changes this

Re: ospfd: allow specifying area by number as well as id

2019-04-30 Thread Remi Locherer
o convert that number to an address for > > > >> use > > > >> in openbsd. eg, i was given area 700 in one place, which is 0.0.2.188 > > > >> as an address. super annoying. > > > >> > > > >> so this changes the

Re: ospfd: allow specifying area by number as well as id

2019-04-29 Thread Gregory Edigarov
this changes the ospfd parser so it accepts both a number or address. i also changed it so it prints the number by default, which may be contentious. the manpage is slightly tweaked too. thoughts? why don't just add something like 'convert' to ospfctl? wouldn't it be easier

Re: ospfd: allow specifying area by number as well as id

2019-04-29 Thread Alexander Bluhm
SPF Area ID's are typically formatted as IP addresses). > so this changes the ospfd parser so it accepts both a number or address. > i also changed it so it prints the number by default, which may be > contentious. the manpage is slightly tweaked too. Please keep it as it is. os

Re: ospfd: allow specifying area by number as well as id

2019-04-29 Thread Stuart Henderson
at 11:53:27AM +1000, David Gwynne wrote: > > >> it's always bothered me that i config areas on a crisco using a number, > > >> but then have to think hard to convert that number to an address for use > > >> in openbsd. eg, i was given area 700 in one place, which

Re: ospfd: allow specifying area by number as well as id

2019-04-29 Thread Sebastian Benoit
config areas on a crisco using a number, > >> but then have to think hard to convert that number to an address for use > >> in openbsd. eg, i was given area 700 in one place, which is 0.0.2.188 > >> as an address. super annoying. > >> > >> so this chang

Re: ospfd: allow specifying area by number as well as id

2019-04-29 Thread David Gwynne
mber to an address for use >> in openbsd. eg, i was given area 700 in one place, which is 0.0.2.188 >> as an address. super annoying. >> >> so this changes the ospfd parser so it accepts both a number or address. >> i also changed it so it prints the number by default, wh

Re: ospfd: allow specifying area by number as well as id

2019-04-28 Thread Remi Locherer
0.0.2.188 > as an address. super annoying. > > so this changes the ospfd parser so it accepts both a number or address. > i also changed it so it prints the number by default, which may be > contentious. the manpage is slightly tweaked too. > > thoughts? I like it to be

ospfd: allow specifying area by number as well as id

2019-04-28 Thread David Gwynne
it's always bothered me that i config areas on a crisco using a number, but then have to think hard to convert that number to an address for use in openbsd. eg, i was given area 700 in one place, which is 0.0.2.188 as an address. super annoying. so this changes the ospfd parser so it accepts

Re: ospfd: Apply netmask to stub prefixes before adding the route to the route table

2019-04-04 Thread Claudio Jeker
e wrote: > > >> I kept finding I had a lingering /30 route when I turned off one of my > > >> test boxes. I tracked it down to ospfd sending RTM_ADD for a stub > > >> network with the non-masked prefix. The RTM_ADD path applies the mask > > >> inside t

Re: ospfd: Apply netmask to stub prefixes before adding the route to the route table

2019-04-04 Thread Remi Locherer
f one of my > >> test boxes. I tracked it down to ospfd sending RTM_ADD for a stub > >> network with the non-masked prefix. The RTM_ADD path applies the mask > >> inside the kernel, so the route got added as expected, but the > >> RTM_DELETE enforces an exact match,

Re: ospfd: Apply netmask to stub prefixes before adding the route to the route table

2019-04-02 Thread Mitchell Krome
On 2/04/2019 3:30 pm, Remi Locherer wrote: > Hi Mitchell > > On Sat, Mar 30, 2019 at 04:10:09PM +1000, Mitchell Krome wrote: >> I kept finding I had a lingering /30 route when I turned off one of my >> test boxes. I tracked it down to ospfd sending RTM_ADD for a stub &g

Re: ospfd: Apply netmask to stub prefixes before adding the route to the route table

2019-04-01 Thread Remi Locherer
Hi Mitchell On Sat, Mar 30, 2019 at 04:10:09PM +1000, Mitchell Krome wrote: > I kept finding I had a lingering /30 route when I turned off one of my > test boxes. I tracked it down to ospfd sending RTM_ADD for a stub > network with the non-masked prefix. The RTM_ADD path applies the mask

ospfd: Apply netmask to stub prefixes before adding the route to the route table

2019-03-29 Thread Mitchell Krome
I kept finding I had a lingering /30 route when I turned off one of my test boxes. I tracked it down to ospfd sending RTM_ADD for a stub network with the non-masked prefix. The RTM_ADD path applies the mask inside the kernel, so the route got added as expected, but the RTM_DELETE enforces an exact

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Jeremie Courreges-Anglas
On Mon, Mar 25 2019, Remi Locherer wrote: [...] > This works and it makes sense to me. > > The log message is a bit lengthy compared to other log messages produced > by ospfd. Maybe something like this: "router-id changed: restart required" Yep, fine with me. > But

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Remi Locherer
oad because it doesn't make sense > > sending the config to all the children if we know we're going to abort. > > Your patch was mangled (long line wrapped) but the changes looked good. > Here's an updated version which tweaks punc

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Sebastian Benoit
p into ospf_reload because it doesn't make sense > > sending the config to all the children if we know we're going to abort. > > Your patch was mangled (long line wrapped) but the changes looked good. > Here's an updated version which tweaks punctuation and case (to match > the

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Jeremie Courreges-Anglas
d. > > I moved the check up into ospf_reload because it doesn't make sense > sending the config to all the children if we know we're going to abort. Your patch was mangled (long line wrapped) but the changes looked good. Here's an updated version which tweaks punctuation and cas

Re: ospfd: Warn when the router ID changes during config reload

2019-03-23 Thread Mitchell Krome
fig to take effect after changing the router id. I moved the check up into ospf_reload because it doesn't make sense sending the config to all the children if we know we're going to abort. Mitchell diff --git a/usr.sbin/ospfd/ospfd.c b/usr.sbin/ospfd/ospfd.c index d01a2fa66..bc2

Re: ospfd: Warn when the router ID changes during config reload

2019-03-23 Thread Theo de Raadt
Sebastian Benoit wrote: > Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: > > Was messing around with ospf and got myself into a situation where the > > router ID's were the same on two boxes because I only did a reload on > > one of them when I changed the loopback IP's. >

Re: ospfd: Warn when the router ID changes during config reload

2019-03-23 Thread Sebastian Benoit
e. not load the new config at all. You just add a warning, but who reads the log at that point? ospf6d cant reload its config at this time, so not a problem there. /Benno > Mitchell > > > diff --git a/usr.sbin/ospfd/ospfd.c b/usr.sbin/ospfd/ospfd.c > index d01a2fa66..db59fc7

ospfd: Warn when the router ID changes during config reload

2019-03-23 Thread Mitchell Krome
uch). Same patch can probably be applied to ospf6d if people think it's useful. Mitchell diff --git a/usr.sbin/ospfd/ospfd.c b/usr.sbin/ospfd/ospfd.c index d01a2fa66..db59fc718 100644 --- a/usr.sbin/ospfd/ospfd.c +++ b/usr.sbin/ospfd/ospfd.c @@ -694,6 +694,10 @@ merge_config(struct ospfd_con

Re: ospfd: send router lsa when removing an interface

2019-01-02 Thread Claudio Jeker
affected route > might be used by other routers a long time after removing it from the > config (until the LSA ages out). > > Below diff fixes this. > > OK? Makes sense, OK claudio@ > Index: ospfd.c > ======= > R

ospfd: send router lsa when removing an interface

2019-01-01 Thread Remi Locherer
(until the LSA ages out). Below diff fixes this. OK? Remi Index: ospfd.c === RCS file: /cvs/src/usr.sbin/ospfd/ospfd.c,v retrieving revision 1.102 diff -u -p -r1.102 ospfd.c --- ospfd.c 28 Dec 2018 19:25:10 - 1.102

Re: ospfd: fib-priority

2018-12-28 Thread Claudio Jeker
t kr_state. > > > > > > OK? > > > > Remi > > > > > > > > cvs diff: Diffing . > > Index: kroute.c > > === > > RCS file: /cvs/src/usr.sbin/ospfd/kroute.c,v > > retrieving revision 1.111 > > diff -u -p -r1.111 k

Re: ospfd: fib-priority

2018-12-28 Thread Remi Locherer
kr_dispatch_msg() needs to be reset. Because of that I added fib_prio to > struct kr_state. > > > OK? > > Remi > > > > cvs diff: Diffing . > Index: kroute.c > === > RCS file: /cvs/src/usr.sbin/

ospfd: fib-priority

2018-12-10 Thread Remi Locherer
. Index: kroute.c === RCS file: /cvs/src/usr.sbin/ospfd/kroute.c,v retrieving revision 1.111 diff -u -p -r1.111 kroute.c --- kroute.c10 Jul 2018 11:49:04 - 1.111 +++ kroute.c9 Dec 2018 21:39:46 - @@ -45,6 +45,7 @@ stru

Re: ospfd: pledge parent process

2018-09-02 Thread Remi Locherer
On Sat, Sep 01, 2018 at 10:38:09PM +0200, Sebastian Benoit wrote: > Remi Locherer(remi.loche...@relo.ch) on 2018.09.01 21:53:21 +0200: > > Hi, > > > > Since slaacd is able to use pledge in the parent process I thought it may > > be possible for ospfd too. > > &

Re: ospfd: pledge parent process

2018-09-02 Thread Remi Locherer
the parent process I thought it may > > > be possible for ospfd too. > > > > > > It works fine until ospfd gets reloaded. At this point it uses setsockopt > > > to set the priority filter on the routing socket. > > > > > > Since I could not f

Re: ospfd: pledge parent process

2018-09-01 Thread Remi Locherer
On Sat, Sep 01, 2018 at 10:38:09PM +0200, Sebastian Benoit wrote: > Remi Locherer(remi.loche...@relo.ch) on 2018.09.01 21:53:21 +0200: > > Hi, > > > > Since slaacd is able to use pledge in the parent process I thought it may > > be possible for ospfd too. > > &

Re: ospfd: pledge parent process

2018-09-01 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2018.09.01 21:53:21 +0200: > Hi, > > Since slaacd is able to use pledge in the parent process I thought it may > be possible for ospfd too. > > It works fine until ospfd gets reloaded. At this point it uses setsockopt > to set the p

ospfd: pledge parent process

2018-09-01 Thread Remi Locherer
Hi, Since slaacd is able to use pledge in the parent process I thought it may be possible for ospfd too. It works fine until ospfd gets reloaded. At this point it uses setsockopt to set the priority filter on the routing socket. Since I could not find a promise for this I extended wroute. Does

Re: ospfd: prevent additional ospfd from starting

2018-08-29 Thread Florian Obser
t; > > > the main process. > > > > > > New diff below creates the control socket in the main process and passes > > > it > > > to the ospf engine later on. The connect check on the control socket now > > > happens very early. > > >

Re: ospfd: prevent additional ospfd from starting

2018-08-28 Thread Claudio Jeker
ain process. > > > > > > New diff below creates the control socket in the main process and passes > > > it > > > to the ospf engine later on. The connect check on the control socket now > > > happens very early. > > >

Re: ospfd: prevent additional ospfd from starting

2018-08-28 Thread Remi Locherer
n to > > > pledge (stdio rpath sendfd wroute) and eventually unveil (read ospfd.conf) > > > the main process. > > > > New diff below creates the control socket in the main process and passes it > > to the ospf engine later on. The connect check on the control soc

Re: ospfd: prevent additional ospfd from starting

2018-08-27 Thread Claudio Jeker
gt; On Tue, Aug 21, 2018 at 05:54:18PM +0100, Stuart Henderson wrote: > > > > > On 2018/08/21 17:16, Remi Locherer wrote: > > > > > > Hi tech, > > > > > > > > > > > > recently we had a short outage in our network. A script st

Re: ospfd: prevent additional ospfd from starting

2018-08-27 Thread Remi Locherer
> > On 2018/08/21 17:16, Remi Locherer wrote: > > > > > Hi tech, > > > > > > > > > > recently we had a short outage in our network. A script started an > > > > > additional > > > > > ospfd instance because the -n flag f

Re: ospfd: prevent additional ospfd from starting

2018-08-24 Thread Remi Locherer
> > > > > > > recently we had a short outage in our network. A script started an > > > > additional > > > > ospfd instance because the -n flag for config test was missing. > > > > > > This is a problem with bgpd as well, last time I

Re: ospfd: prevent additional ospfd from starting

2018-08-23 Thread Claudio Jeker
script started an > > > additional > > > ospfd instance because the -n flag for config test was missing. > > > > This is a problem with bgpd as well, last time I did this it killed one of > > the > > *other* routers on the network (i.e. not just the one where

Re: ospfd: prevent additional ospfd from starting

2018-08-21 Thread Remi Locherer
On Tue, Aug 21, 2018 at 05:54:18PM +0100, Stuart Henderson wrote: > On 2018/08/21 17:16, Remi Locherer wrote: > > Hi tech, > > > > recently we had a short outage in our network. A script started an > > additional > > ospfd instance because the -n flag for config

Re: ospfd: prevent additional ospfd from starting

2018-08-21 Thread Denis Fondras
On Tue, Aug 21, 2018 at 05:16:47PM +0200, Remi Locherer wrote: > Hi tech, > > recently we had a short outage in our network. A script started an additional > ospfd instance because the -n flag for config test was missing. > > What then happend was not nice: > - The new ospfd

  1   2   3   >