Hello,
> > > +ipsp_delete_acquire_locked(struct ipsec_acquire *ipa)
> > > +{
> > > + if (timeout_del(>ipa_timeout) == 1)
> > > + refcnt_rele(>ipa_refcnt);
> >^^
> > can we also put ASSERT/check into this branch
> > to verify we are no releasing the
On Mon, Mar 14, 2022 at 11:09:48AM +0100, Alexandr Nedvedicky wrote:
> 667 ipsec_delete_policy(struct ipsec_policy *ipo)
>
> 668 {
> 669 struct ipsec_acquire *ipa;
> 670 struct radix_node_head *rnh;
> 671 struct radix_node *rn
Hello,
On Tue, Mar 15, 2022 at 12:58:48AM +0300, Vitaliy Makkoveev wrote:
> >
> >I think local var `ipa` needs to be initialized to NULL
> >to avoid random value/pointer when no `ipa` for given `seq`
> >is found.
> >
> >ipsp_pending_acquire() plays the same gamble.
>
> #define
> On 15 Mar 2022, at 00:45, Alexandr Nedvedicky
> wrote:
>
> Hello,
>
> On Tue, Mar 15, 2022 at 12:37:00AM +0300, Vitaliy Makkoveev wrote:
>> Hi,
>>
>> Why do you want to initialize `ipa’ variable in
>> ipsp_pending_acquire() and ipsec_get_acquire()? This doesn’t
>> require.
>
>after
Hello,
On Tue, Mar 15, 2022 at 12:37:00AM +0300, Vitaliy Makkoveev wrote:
> Hi,
>
> Why do you want to initialize `ipa’ variable in
> ipsp_pending_acquire() and ipsec_get_acquire()? This doesn’t
> require.
after looking at code with bluhm's diff applied I see this:
936 struct
Hi,
Why do you want to initialize `ipa’ variable in
ipsp_pending_acquire() and ipsec_get_acquire()? This doesn’t
require.
> On 14 Mar 2022, at 13:09, Alexandr Nedvedicky
> wrote:
>
> Hello,
>
>
>
> changes looks good. just few nits.
>
>I took a closer look at ipsec_delete_policy():
>
Hello,
changes looks good. just few nits.
I took a closer look at ipsec_delete_policy():
667 ipsec_delete_policy(struct ipsec_policy *ipo)
668 {
669 struct ipsec_acquire *ipa;
670 struct radix_node_head *rnh;
671
