Re: [PATCH] Disable USB bus probes

2015-04-27 Thread Dimitris Papastamos
On Mon, Apr 27, 2015 at 11:18:55AM +0200, Martin Pieuchot wrote: On 22/04/15(Wed) 10:29, Dimitris Papastamos wrote: [...] On a side note, What do you think of using a sysctl instead of an ioctl? I guess an ioctl will do but it would make it easy for people to disable this at boot time by

Re: [PATCH] Disable USB bus probes

2015-04-27 Thread Martin Pieuchot
On 22/04/15(Wed) 10:29, Dimitris Papastamos wrote: [...] On a side note, What do you think of using a sysctl instead of an ioctl? I guess an ioctl will do but it would make it easy for people to disable this at boot time by simply adding the relevant knob in /etc/sysctl.conf. Otherwise I

Re: [PATCH] Disable USB bus probes

2015-04-22 Thread Martin Pieuchot
On 17/04/15(Fri) 16:47, Dimitris Papastamos wrote: Hi, This patch adds an option to usbdevs(8) to disable USB bus probing at runtime. The operation is restricted to the root user. It would be nice to show if probing is on or off, for example # usbdevs -p bus probing: on # usbdevs -p off

Re: [PATCH] Disable USB bus probes

2015-04-22 Thread Dimitris Papastamos
Below is an updated diff. I will add the documentation bits soonish once I've tested all possible configurations as you requested. I am also planning to rework the structure of usbdevs.c as it is a bit confusing currently but that will happen incrementally after this diff. Index:

Re: [PATCH] Disable USB bus probes

2015-04-22 Thread Dimitris Papastamos
On Wed, Apr 22, 2015 at 08:54:34AM +0200, Martin Pieuchot wrote: On 17/04/15(Fri) 16:47, Dimitris Papastamos wrote: Hi, This patch adds an option to usbdevs(8) to disable USB bus probing at runtime. The operation is restricted to the root user. It would be nice to show if probing is