Re: [PATCH] parse ! on hostname.if for autoinstall

2018-11-09 Thread Florian Obser
I have a use for this. Do the chicken scratches allow reject routes? I currently have bunch of lines like this in my hostname.if files: !route -q add -net 2a01:db8::/48 ::1 -reject On Fri, Nov 09, 2018 at 06:16:53PM -0600, Todd T. Fries wrote: > Would there be any merit in contemplating a syntax

Re: [PATCH] parse ! on hostname.if for autoinstall

2018-11-09 Thread Julien Dhaille
Permit adding routes in installer was my goal :) Le 10/11/2018 à 01:16, Todd T. Fries a écrit : > Would there be any merit in contemplating a syntax that would permit > adding routes in hostname.if so the installer could pick that up and > avoid the much more corner case shell disaster scenarios?

Re: [PATCH] parse ! on hostname.if for autoinstall

2018-11-09 Thread Todd T. Fries
Would there be any merit in contemplating a syntax that would permit adding routes in hostname.if so the installer could pick that up and avoid the much more corner case shell disaster scenarios? note .. 'route add' no longer requires -inet6 so we would not need a special route6 syntax. For

Re: [PATCH] parse ! on hostname.if for autoinstall

2018-11-09 Thread Julien Dhaille
diff --git distrib/miniroot/install.sub distrib/miniroot/install.sub index bce1fa50358..31dbafdc95d 100644 --- distrib/miniroot/install.sub +++ distrib/miniroot/install.sub @@ -2319,8 +2319,11 @@ parse_hn_line() { _cmds[${#_cmds[*]}]="ifconfig $_if ${_c[@]} up;dhclient $_if"

Re: [PATCH] parse ! on hostname.if for autoinstall

2018-11-09 Thread Gilles Chehade
On Fri, Nov 09, 2018 at 05:10:00PM +0100, Julien Dhaille wrote: > Hi. > > During auto upgrade via the auto_upgrade.conf file (no DHCP server), > shell commands are skipped. > This small diff is coming from parse_hn_line() in /etc/netstart, thus, > it keeps the behavior similar. > I think it's

Re: [PATCH] parse ! on hostname.if for autoinstall

2018-11-09 Thread Theo de Raadt
This was intentional because a user could put crazy script commands in the files which don't work in the bsd.rd context. bsd.rd is quite gutted. That means some circumstances could fail quite badly Could be reconsidered... > During auto upgrade via the auto_upgrade.conf file (no DHCP server),