Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Duncan Roe
On Sun, Sep 27, 2020 at 08:27:24PM -0600, Theo de Raadt wrote: > Duncan Roe wrote: > > > > I disagree with your plan. This kind of "force it off" programming is > > > typical. > > > > > Might be typical, but I think it's sloppy. > > I don't think it is sloppy. > > Instead, I think your

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Theo de Raadt
Duncan Roe wrote: > > I disagree with your plan. This kind of "force it off" programming is > > typical. > > > Might be typical, but I think it's sloppy. I don't think it is sloppy. Instead, I think your additional logic complicates review.

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Duncan Roe
On Sun, Sep 27, 2020 at 07:53:27PM -0600, Theo de Raadt wrote: > Duncan Roe wrote: > > > On Sun, Sep 27, 2020 at 02:18:21PM -0600, Bob Beck wrote: > > > On Sun, Sep 27, 2020 at 02:46:39PM +1000, Duncan Roe wrote: > > > > The motivation for this is to make debug logs less confusing. > > > > > >

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Theo de Raadt
Duncan Roe wrote: > On Sun, Sep 27, 2020 at 02:18:21PM -0600, Bob Beck wrote: > > On Sun, Sep 27, 2020 at 02:46:39PM +1000, Duncan Roe wrote: > > > The motivation for this is to make debug logs less confusing. > > > > What is this fixing and what behavior are you changing? > > You can only see

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Duncan Roe
On Sun, Sep 27, 2020 at 02:18:21PM -0600, Bob Beck wrote: > On Sun, Sep 27, 2020 at 02:46:39PM +1000, Duncan Roe wrote: > > The motivation for this is to make debug logs less confusing. > > What is this fixing and what behavior are you changing? You can only see the difference when running nc

Re: [PATCH netcat] Only force fd's to -1 once

2020-09-27 Thread Bob Beck
On Sun, Sep 27, 2020 at 02:46:39PM +1000, Duncan Roe wrote: > The motivation for this is to make debug logs less confusing. What is this fixing and what behavior are you changing? > > All changed lines have previously demonstrated the problem. > > Signed-off-by: Duncan Roe > --- >