Re: [patch] crontab(5) add -n option to suppress mail when the run was successful

2018-06-13 Thread Jason McIntyre
On Tue, Jun 12, 2018 at 09:13:05PM +0200, Job Snijders wrote: > On Tue, Jun 12, 2018 at 09:54:47AM -0600, Theo de Raadt wrote: > > I would prefer if the -q and -n descriptions were in a table. I dislike > > the ancient style of describing such things inline (harder to spot). > > And it really fall

Re: [patch] crontab(5) add -n option to suppress mail when the run was successful

2018-06-12 Thread Theo de Raadt
Job Snijders wrote: > On Tue, Jun 12, 2018 at 09:54:47AM -0600, Theo de Raadt wrote: > > I would prefer if the -q and -n descriptions were in a table. I dislike > > the ancient style of describing such things inline (harder to spot). > > And it really falls down when there are multiple ones. Ho

Re: [patch] crontab(5) add -n option to suppress mail when the run was successful

2018-06-12 Thread Job Snijders
On Tue, Jun 12, 2018 at 09:54:47AM -0600, Theo de Raadt wrote: > I would prefer if the -q and -n descriptions were in a table. I dislike > the ancient style of describing such things inline (harder to spot). > And it really falls down when there are multiple ones. How do you > feel about that jmc

Re: [patch] crontab(5) add -n option to suppress mail when the run was successful

2018-06-12 Thread Theo de Raadt
Todd C. Miller wrote: > > --- usr.sbin/cron/crontab.5 > > +++ usr.sbin/cron/crontab.5 > > @@ -193,14 +193,27 @@ will be changed into newline characters, and all data > > after the first > > .Ql % > > will be sent to the command as standard input. > > +.Pp > > +If the > > +.Ar command > > +fiel

Re: [patch] crontab(5) add -n option to suppress mail when the run was successful

2018-06-12 Thread Todd C. Miller
This is an oft-requested feature. The diff looks good, I've made some minor comments in-line. - todd On Mon, 11 Jun 2018 20:23:11 -, Job Snijders wrote: > diff --git usr.sbin/cron/crontab.5 usr.sbin/cron/crontab.5 > index 9c2e651980a..700010faadf 100644 > --- usr.sbin/cron/crontab.5 > +++

Re: [patch] crontab(5) add -n option to suppress mail when the run was successful

2018-06-12 Thread Craig Skinner
On Mon, 11 Jun 2018 20:23:11 + Job Snijders wrote: > > With the above example crontab(5) entry you'll only receive a mail > from cron(8) if the cp(1) encountered some kind of error. Good one Job. Related: https://marc.info/?l=openbsd-tech&m=142075623225995 Cheers, -- Craig Skinne