Re: Add man parameter for HTML pager

2020-06-15 Thread Abel Romero Prez
On 2020-06-15 20:21, Ingo Schwarze wrote: > Hi Abel, > > i committed a tweaked version of your patch with these changes: > > - pass pointers to structs around, don't pass structs by value > - no need for an additional automatic variable for the URI > - no need for comments similar to:

Re: Add man parameter for HTML pager

2020-06-15 Thread Abel Romero Prez
It is done. On 2020-06-15 20:31, Theo Buehler wrote: > On Mon, Jun 15, 2020 at 08:21:05PM +0200, Ingo Schwarze wrote: >> Your patch was mangled in at least one way. Most lines were prefixed >> with a bogus space character; i did not check whether it was also >> mangled in other ways. > >

Re: Add man parameter for HTML pager

2020-06-15 Thread Theo Buehler
On Mon, Jun 15, 2020 at 08:21:05PM +0200, Ingo Schwarze wrote: > Your patch was mangled in at least one way. Most lines were prefixed > with a bogus space character; i did not check whether it was also > mangled in other ways. User-Agent: Mozilla/5.0 (X11; OpenBSD amd64; rv:68.0) Gecko/20100101

Re: Add man parameter for HTML pager

2020-06-15 Thread Ingo Schwarze
Hi Abel, i committed a tweaked version of your patch with these changes: - pass pointers to structs around, don't pass structs by value - no need for an additional automatic variable for the URI - no need for comments similar to: i++; /* increment i */ - only use file:// when -O tag was

Re: Add man parameter for HTML pager

2020-06-15 Thread Romero Pérez , Abel
Hi again, I have added the modifications I think you told me. Also I changed the extension of the tmp file then it can be interpreted as HTML by any browser used as pager. The extension is set when using html format. Now this works: MANPAGER="lynx" ./man -T html -O tag=k pfctl (no need to

Re: Add man parameter for HTML pager

2020-06-15 Thread Romero Pérez , Abel
Thanks for the handy answer, Ingo. I am going to develop it better. On 2020-06-15 04:13, Ingo Schwarze wrote: Hi Abel, Romero Perez, Abel wrote on Mon, Jun 15, 2020 at 03:06:26AM +0200: Romero Perez, Abel wrote: I tried to view the manuals in HTML format with lynx, but I couldn't I

Re: Add man parameter for HTML pager

2020-06-14 Thread Ingo Schwarze
Hi Abel, Romero Perez, Abel wrote on Mon, Jun 15, 2020 at 03:06:26AM +0200: > Romero Perez, Abel wrote: >> I tried to view the manuals in HTML format with lynx, but I couldn't I assume what you mean is that you could, but the "-O tag" option had no effect. >> because lynx and links can't

Re: Add man parameter for HTML pager

2020-06-14 Thread Romero Pérez , Abel
Sorry, I didn't reviewed the code well. The first diff has some bugs. As follows the stable diff (please, review): Index: main.c === RCS file: /cvs/src/usr.bin/mandoc/main.c,v retrieving revision 1.252 diff -u -p -r1.252 main.c ---