Re: PATCH: fix bug in handling genmask

2014-01-21 Thread Claudio Jeker
On Wed, Jan 22, 2014 at 06:29:57AM +0800, Kieran Devlin wrote: hope this time i get the part ?poke claudio@? right a. fix a bug. b. get rid of some junk in ?mask_rnhead?. c. forbid unprivileged user to insert ?genmask' into ?mask_rnhead' bug is in this line memcmp((caddr_t

Re: PATCH: fix bug in handling genmask

2013-12-28 Thread Bret Lambert
IIRC, I'd talked to both claudio and sthen about removing genmask, as it's unused and slightly nonsensical. Maybe we should just do it, if there are actual bugs lurking therein? On Sat, Dec 28, 2013 at 03:57:04AM +0800, Kieran Devlin wrote: re-send this patch, loop in claudio@ maybe someone

Re: PATCH: fix bug in handling genmask

2013-12-28 Thread Kieran Devlin
maybe, one problem at a time? first, whether there is actually a bug there, this patch fix it? and then this removing genmask discussion as i understand, unless you guys had already reached a conclusion once, there might be no immediate result and as blambert@ mentioned, whether it is really a