On Sat, Jan 06, 2018 at 07:33:16PM -0800, Carlos Cardenas wrote: > Attached are regress tests for the cdrom keyword. > > Comments? Ok? > > +--+ > Carlos
seems ok to me > Index: Makefile > =================================================================== > RCS file: /home/los/cvs/src/regress/usr.sbin/vmd/config/Makefile,v > retrieving revision 1.3 > diff -u -p -r1.3 Makefile > --- Makefile 11 Nov 2017 02:54:42 -0000 1.3 > +++ Makefile 7 Jan 2018 03:27:10 -0000 > @@ -2,10 +2,10 @@ > > VMD ?= /usr/sbin/vmd > > -VMD_PASS=boot-keyword memory-round memory-just-enough > +VMD_PASS=boot-keyword memory-round memory-just-enough cdrom-keyword > VMD_FAIL=kernel-keyword too-few-ram vm-name-too-long too-many-ifs \ > boot-name-too-long disk-path-too-long too-many-disks \ > - switch-no-interface switch-no-add > + switch-no-interface switch-no-add cdrom-name-too-long > > REGRESS_TARGETS= > > Index: vmd-fail-cdrom-name-too-long.conf > =================================================================== > RCS file: vmd-fail-cdrom-name-too-long.conf > diff -N vmd-fail-cdrom-name-too-long.conf > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ vmd-fail-cdrom-name-too-long.conf 7 Jan 2018 03:21:59 -0000 > @@ -0,0 +1,6 @@ > +# $OpenBSD$ > +# Fail on cdrom path (> 128) > +iso="/some/absolutepath/somewhere/abcdefghijklmnopqrstuvwxyz0123456789/abcdefghijklmnopqrstuvwxyz0123456789/abcdefghijklmnopqrstuvwxyz0123456789/cd62.iso" > +vm "x" { > + cdrom $iso > +} > Index: vmd-fail-cdrom-name-too-long.ok > =================================================================== > RCS file: vmd-fail-cdrom-name-too-long.ok > diff -N vmd-fail-cdrom-name-too-long.ok > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ vmd-fail-cdrom-name-too-long.ok 7 Jan 2018 03:21:59 -0000 > @@ -0,0 +1 @@ > +5: cdrom name too long > Index: vmd-pass-cdrom-keyword.conf > =================================================================== > RCS file: vmd-pass-cdrom-keyword.conf > diff -N vmd-pass-cdrom-keyword.conf > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ vmd-pass-cdrom-keyword.conf 7 Jan 2018 03:21:59 -0000 > @@ -0,0 +1,8 @@ > +# $OpenBSD$ > +# Pass on cdrom keyword > + > +vm "x" { > + memory 1G > + cdrom "cd62.iso" > + disable > +} > Index: vmd-pass-cdrom-keyword.ok > =================================================================== > RCS file: vmd-pass-cdrom-keyword.ok > diff -N vmd-pass-cdrom-keyword.ok > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ vmd-pass-cdrom-keyword.ok 7 Jan 2018 03:21:59 -0000 > @@ -0,0 +1 @@ > +configuration OK