Re: VMD: revise check for regular files on disks

2018-01-05 Thread Carlos Cardenas
Jeremie Courreges-Anglas wrote: > On Wed, Jan 03 2018, Carlos Cardenas wrote: > > Howdy. > > > > Attached is a patch to address a TOCTOU issue with checking to > > ensure disks are regular files, reported by jca@ . > > > > Comments? Ok? > > A bit late,

Re: VMD: revise check for regular files on disks

2018-01-05 Thread Mike Larkin
On Fri, Jan 05, 2018 at 08:26:21AM +0100, Jeremie Courreges-Anglas wrote: > On Wed, Jan 03 2018, Carlos Cardenas wrote: > > Howdy. > > > > Attached is a patch to address a TOCTOU issue with checking to > > ensure disks are regular files, reported by jca@ . > > > > Comments?

Re: VMD: revise check for regular files on disks

2018-01-04 Thread Jeremie Courreges-Anglas
On Wed, Jan 03 2018, Carlos Cardenas wrote: > Howdy. > > Attached is a patch to address a TOCTOU issue with checking to > ensure disks are regular files, reported by jca@ . > > Comments? Ok? A bit late, but ok. While here, if the S_ISREG check fails there is no meaningful

Re: VMD: revise check for regular files on disks

2018-01-04 Thread Mike Larkin
On Thu, Jan 04, 2018 at 07:14:54AM -0800, Carlos Cardenas wrote: > Mike Larkin wrote: > > > On Wed, Jan 03, 2018 at 08:03:56PM -0800, Carlos Cardenas wrote: > > > Howdy. > > > > > > Attached is a patch to address a TOCTOU issue with checking to > > > ensure disks are

Re: VMD: revise check for regular files on disks

2018-01-04 Thread Carlos Cardenas
Mike Larkin wrote: > On Wed, Jan 03, 2018 at 08:03:56PM -0800, Carlos Cardenas wrote: > > Howdy. > > > > Attached is a patch to address a TOCTOU issue with checking to > > ensure disks are regular files, reported by jca@ . > > > > Comments? Ok? > > > > +--+ > > Carlos >

Re: VMD: revise check for regular files on disks

2018-01-03 Thread Mike Larkin
On Wed, Jan 03, 2018 at 08:03:56PM -0800, Carlos Cardenas wrote: > Howdy. > > Attached is a patch to address a TOCTOU issue with checking to > ensure disks are regular files, reported by jca@ . > > Comments? Ok? > > +--+ > Carlos > Index: config.c >