Re: acpithinkpad(4): port-replicator hkey event

2018-05-21 Thread Mike Larkin
On Mon, May 21, 2018 at 12:55:13PM +0200, Tobias Tschinkowitz wrote: > On Mon, May 21, 2018 at 11:56:37AM +0200, Stefan Sperling wrote: > > On Mon, May 21, 2018 at 11:35:54AM +0200, Tobias Tschinkowitz wrote: > > > As the last diff still had formatting issues i fixed that. > > > > OK by me. > >

Re: acpithinkpad(4): port-replicator hkey event

2018-05-21 Thread Tobias Tschinkowitz
On Mon, May 21, 2018 at 11:56:37AM +0200, Stefan Sperling wrote: > On Mon, May 21, 2018 at 11:35:54AM +0200, Tobias Tschinkowitz wrote: > > As the last diff still had formatting issues i fixed that. > > OK by me. > > Nitpick: There are overlong lines here (please stay <= 80 columns). > > > +

Re: acpithinkpad(4): port-replicator hkey event

2018-05-21 Thread Stefan Sperling
On Mon, May 21, 2018 at 11:35:54AM +0200, Tobias Tschinkowitz wrote: > As the last diff still had formatting issues i fixed that. OK by me. Nitpick: There are overlong lines here (please stay <= 80 columns). > + sc->sc_sens[THINKPAD_SENSOR_PORTREPL].status = > SENSOR_S_OK;

Re: acpithinkpad(4): port-replicator hkey event

2018-05-21 Thread Tobias Tschinkowitz
On Sun, May 06, 2018 at 11:43:43PM +0200, Tobias Tschinkowitz wrote: > On Sun, May 06, 2018 at 09:31:55AM -0700, Mike Larkin wrote: > > On Fri, May 04, 2018 at 08:28:04PM +0200, Tobias Tschinkowitz wrote: > > > Hi @tech, > > > > > > i thought it would be a good idea to delegate the

Re: acpithinkpad(4): port-replicator hkey event

2018-05-06 Thread Tobias Tschinkowitz
On Sun, May 06, 2018 at 09:31:55AM -0700, Mike Larkin wrote: > On Fri, May 04, 2018 at 08:28:04PM +0200, Tobias Tschinkowitz wrote: > > Hi @tech, > > > > i thought it would be a good idea to delegate the port-replicator > > docking event to the sysctl(2) hw.sensors substree so that if the > >

Re: acpithinkpad(4): port-replicator hkey event

2018-05-06 Thread Mike Larkin
On Fri, May 04, 2018 at 08:28:04PM +0200, Tobias Tschinkowitz wrote: > Hi @tech, > > i thought it would be a good idea to delegate the port-replicator > docking event to the sysctl(2) hw.sensors substree so that if the > thinkpad gets docked/undocked one could react to it by using > sensorsd(8).