Re: change closelog(3) description

2017-08-30 Thread Todd C. Miller
On Wed, 30 Aug 2017 12:49:43 -0600, "Theo de Raadt" wrote: > > > How about "discard resources", or something more nebulous. Especially > > > if it frightens signal handler authors. > > > > I understand what you are getting at but that seems so vague as to > > be unhelpful. > > Precisely how is

Re: change closelog(3) description

2017-08-30 Thread Theo de Raadt
> > How about "discard resources", or something more nebulous. Especially > > if it frightens signal handler authors. > > I understand what you are getting at but that seems so vague as to > be unhelpful. Precisely how is it vague? The manual is telling people to follow an open/close idiom,

Re: change closelog(3) description

2017-08-30 Thread Todd C. Miller
On Wed, 30 Aug 2017 12:24:38 -0600, "Theo de Raadt" wrote: > How about "discard resources", or something more nebulous. Especially > if it frightens signal handler authors. I understand what you are getting at but that seems so vague as to be unhelpful. - todd

Re: change closelog(3) description

2017-08-30 Thread Theo de Raadt
> > On Wed, Aug 30, 2017 at 10:35:16AM -0600, Todd C. Miller wrote: > > > We don't actually have any log file descriptors since we have > > > sendsyslog(2) so make the description a bit more generic. > > > It is also closer to what POSIX says. > > > > > > OK? > > > > The term "log file" could be

Re: change closelog(3) description

2017-08-30 Thread Alexander Bluhm
On Wed, Aug 30, 2017 at 12:09:13PM -0600, Todd C. Miller wrote: > The > .Fn closelog > function will close any file descriptors opened by the > .Fn openlog , > .Fn openlog_r , > .Fn syslog > or > .Fn syslog_r > functions. > > What do you think? OK bluhm@

Re: change closelog(3) description

2017-08-30 Thread Jason McIntyre
On Wed, Aug 30, 2017 at 12:09:13PM -0600, Todd C. Miller wrote: > On Wed, 30 Aug 2017 20:04:57 +0200, Alexander Bluhm wrote: > > > On Wed, Aug 30, 2017 at 10:35:16AM -0600, Todd C. Miller wrote: > > > We don't actually have any log file descriptors since we have > > > sendsyslog(2) so make the

Re: change closelog(3) description

2017-08-30 Thread Todd C. Miller
On Wed, 30 Aug 2017 20:04:57 +0200, Alexander Bluhm wrote: > On Wed, Aug 30, 2017 at 10:35:16AM -0600, Todd C. Miller wrote: > > We don't actually have any log file descriptors since we have > > sendsyslog(2) so make the description a bit more generic. > > It is also closer to what POSIX says. >

Re: change closelog(3) description

2017-08-30 Thread Alexander Bluhm
On Wed, Aug 30, 2017 at 10:35:16AM -0600, Todd C. Miller wrote: > We don't actually have any log file descriptors since we have > sendsyslog(2) so make the description a bit more generic. > It is also closer to what POSIX says. > > OK? The term "log file" could be misunderstood as refering to a