Re: clean /dev from /etc/daily ?

2020-11-23 Thread Raf Czlonka
On Mon, Nov 23, 2020 at 12:53:01PM GMT, Solene Rapenne wrote:
> A common mistake when using dd is to create a file in /dev which
> fills up the space of / and may stay silent until / gets filled up
> by something else that will fail.
> 
> Would it be OK to add this in /etc/daily?
> 
> find /dev -type f ! -name MAKEDEV -delete
> 
> AFAIK /dev should have only MAKEDEV as a regular file.
> hier(7) says /dev only have block and character devices
> with the exception of MAKEDEV.
> 

Whichever way this ends up going - or not - please don't forget
about MAKEDEV.local

Cheers,

Raf



Re: clean /dev from /etc/daily ?

2020-11-23 Thread Solene Rapenne
On Mon, 23 Nov 2020 14:46:29 +
Stuart Henderson :

> On 2020/11/23 09:31, Bryan Steele wrote:
> > On Mon, Nov 23, 2020 at 03:25:34PM +0100, Otto Moerbeek wrote:  
> > > tOn Mon, Nov 23, 2020 at 01:53:01PM +0100, Solene Rapenne wrote:
> > >   
> > > > A common mistake when using dd is to create a file in /dev which
> > > > fills up the space of / and may stay silent until / gets filled up
> > > > by something else that will fail.
> > > > 
> > > > Would it be OK to add this in /etc/daily?
> > > > 
> > > > find /dev -type f ! -name MAKEDEV -delete
> > > > 
> > > > AFAIK /dev should have only MAKEDEV as a regular file.
> > > > hier(7) says /dev only have block and character devices
> > > > with the exception of MAKEDEV.
> > > >   
> > > 
> > > reporting is good, but deleting not.
> > > 
> > >   -Otto  
> > 
> > ^^
> > 
> > I like this option a lot more, as users will get an opportunity to
> > learn.  
> 
> I don't object to reporting (I do object to automatically deleting),
> but realistically for many people who would make this mistake, the
> daily mails are just going to build up unread in /var/mail/$USER...
> 

That's exactly why I thought removing them was better than reporting.
The disk usage is already reported daily.

With the script being run during night, this would also only be
useful for workstation that stay online at the time the script
is run.

In conclusion, it was a bad idea.



Re: clean /dev from /etc/daily ?

2020-11-23 Thread Theo de Raadt
Solene Rapenne  wrote:

> A common mistake when using dd is to create a file in /dev which
> fills up the space of / and may stay silent until / gets filled up
> by something else that will fail.
> 
> Would it be OK to add this in /etc/daily?
> 
> find /dev -type f ! -name MAKEDEV -delete
> 
> AFAIK /dev should have only MAKEDEV as a regular file.
> hier(7) says /dev only have block and character devices
> with the exception of MAKEDEV.

I cannot agree to any of this...



Re: clean /dev from /etc/daily ?

2020-11-23 Thread Stuart Henderson
On 2020/11/23 09:31, Bryan Steele wrote:
> On Mon, Nov 23, 2020 at 03:25:34PM +0100, Otto Moerbeek wrote:
> > tOn Mon, Nov 23, 2020 at 01:53:01PM +0100, Solene Rapenne wrote:
> > 
> > > A common mistake when using dd is to create a file in /dev which
> > > fills up the space of / and may stay silent until / gets filled up
> > > by something else that will fail.
> > > 
> > > Would it be OK to add this in /etc/daily?
> > > 
> > > find /dev -type f ! -name MAKEDEV -delete
> > > 
> > > AFAIK /dev should have only MAKEDEV as a regular file.
> > > hier(7) says /dev only have block and character devices
> > > with the exception of MAKEDEV.
> > > 
> > 
> > reporting is good, but deleting not.
> > 
> > -Otto
> 
> ^^
> 
> I like this option a lot more, as users will get an opportunity to
> learn.

I don't object to reporting (I do object to automatically deleting),
but realistically for many people who would make this mistake, the
daily mails are just going to build up unread in /var/mail/$USER...



Re: clean /dev from /etc/daily ?

2020-11-23 Thread Bryan Steele
On Mon, Nov 23, 2020 at 03:25:34PM +0100, Otto Moerbeek wrote:
> tOn Mon, Nov 23, 2020 at 01:53:01PM +0100, Solene Rapenne wrote:
> 
> > A common mistake when using dd is to create a file in /dev which
> > fills up the space of / and may stay silent until / gets filled up
> > by something else that will fail.
> > 
> > Would it be OK to add this in /etc/daily?
> > 
> > find /dev -type f ! -name MAKEDEV -delete
> > 
> > AFAIK /dev should have only MAKEDEV as a regular file.
> > hier(7) says /dev only have block and character devices
> > with the exception of MAKEDEV.
> > 
> 
> reporting is good, but deleting not.
> 
>   -Otto

^^

I like this option a lot more, as users will get an opportunity to
learn.

-Bryan.



Re: clean /dev from /etc/daily ?

2020-11-23 Thread Bryan Steele
On Mon, Nov 23, 2020 at 03:19:24PM +0100, Mark Kettenis wrote:
> > Date: Mon, 23 Nov 2020 13:53:01 +0100
> > From: Solene Rapenne 
> > 
> > A common mistake when using dd is to create a file in /dev which
> > fills up the space of / and may stay silent until / gets filled up
> > by something else that will fail.
> > 
> > Would it be OK to add this in /etc/daily?
> > 
> > find /dev -type f ! -name MAKEDEV -delete
> > 
> > AFAIK /dev should have only MAKEDEV as a regular file.
> > hier(7) says /dev only have block and character devices
> > with the exception of MAKEDEV.
> 
> Well, the man page is lying as /dev also contains:
> 
> - sockets (/dev/log)
> - symlinks

To be fair, the -type f in solene@'s proposal would preserve all of
those, and just cleanup stray normal files. This does seem to be
mostly harmless, but I do wonder if silently cleaning up after a
users mess is the way to go or not, and should this be done at
boot instead, like the /tmp clearing?

-Bryan.



Re: clean /dev from /etc/daily ?

2020-11-23 Thread Otto Moerbeek
tOn Mon, Nov 23, 2020 at 01:53:01PM +0100, Solene Rapenne wrote:

> A common mistake when using dd is to create a file in /dev which
> fills up the space of / and may stay silent until / gets filled up
> by something else that will fail.
> 
> Would it be OK to add this in /etc/daily?
> 
> find /dev -type f ! -name MAKEDEV -delete
> 
> AFAIK /dev should have only MAKEDEV as a regular file.
> hier(7) says /dev only have block and character devices
> with the exception of MAKEDEV.
> 

reporting is good, but deleting not.

-Otto



Re: clean /dev from /etc/daily ?

2020-11-23 Thread Mark Kettenis
> Date: Mon, 23 Nov 2020 13:53:01 +0100
> From: Solene Rapenne 
> 
> A common mistake when using dd is to create a file in /dev which
> fills up the space of / and may stay silent until / gets filled up
> by something else that will fail.
> 
> Would it be OK to add this in /etc/daily?
> 
> find /dev -type f ! -name MAKEDEV -delete
> 
> AFAIK /dev should have only MAKEDEV as a regular file.
> hier(7) says /dev only have block and character devices
> with the exception of MAKEDEV.

Well, the man page is lying as /dev also contains:

- sockets (/dev/log)
- symlinks



Re: clean /dev from /etc/daily ?

2020-11-23 Thread Leo Unglaub

Hey,
i think this is a great idea. I gave this a try on my machines and 
everything still works great. I asume that this will also reduce the 
number of questions about overgrown / partitions. But i cannot give you 
an OK, i am not an official developer. Just some feedback that it works 
great on my machines.


Thanks so much and greetings
Leo

Am 23.11.2020 um 13:53 schrieb Solene Rapenne:

A common mistake when using dd is to create a file in /dev which
fills up the space of / and may stay silent until / gets filled up
by something else that will fail.

Would it be OK to add this in /etc/daily?

 find /dev -type f ! -name MAKEDEV -delete

AFAIK /dev should have only MAKEDEV as a regular file.
hier(7) says /dev only have block and character devices
with the exception of MAKEDEV.