Re: ffs/msdosfs: Flush cache when updating mount to R/O

2016-10-29 Thread Lampshade 
 What if somebody remounts
 from default options
 (metadata: sync, data: nosync)
 to fully synced
 (metadata: sync, data:   sync)
 
 Example:
# mount | grep /home 
/dev/sd1h on /home type ffs (local)
# /sbin/mount -u -o sync /home   
# mount | grep /home 
/dev/sd1h on /home type ffs (local, synchronous)

 Should this flush cache?

Re: ffs/msdosfs: Flush cache when updating mount to R/O

2016-10-17 Thread Alexander Bluhm 
On Sun, Oct 16, 2016 at 10:24:06AM +0200, Stefan Fritsch wrote:
> On Sun, 16 Oct 2016, Stefan Fritsch wrote:
> > > * When a R/W mount is updated to R/O. I will send patches for this in a 
> > > separate mail.
> 
> Part 2: Use it
> 
> 
> msdosfs & ffs: flush cache if updating mount to r/o
> 
> Other filesystems can be changed later.
> 
> ok?

OK bluhm@

> + /* may be not supported, ignore error */
> + VOP_IOCTL(pmp->pm_devvp, DIOCCACHESYNC, , 
>  FWRITE, FSCRED, p);

This line is too long.