Re: fix confusion between rtlabel and rtable / rdomain

2020-01-08 Thread Klemens Nanni
On Wed, Jan 08, 2020 at 09:50:09AM +0100, Claudio Jeker wrote: > Yes, the label is only applied to routes added after the rtlabel was added > to the interface. Changing this behaviour is outside of the scope of this > fix. Since nobody noticed that ifconfig rtlabel was totally broken for > some

Re: fix confusion between rtlabel and rtable / rdomain

2020-01-08 Thread Claudio Jeker
On Wed, Jan 08, 2020 at 09:27:27AM +0100, Klemens Nanni wrote: > On Wed, Jan 08, 2020 at 08:45:50AM +0100, Claudio Jeker wrote: > > rt_ifa_add() and rt_ifa_del() have a major confusion when it comes to > > rtlabelid (as in labels on a route) vs rtableid (as in routing table id). > > Because of

Re: fix confusion between rtlabel and rtable / rdomain

2020-01-08 Thread Klemens Nanni
On Wed, Jan 08, 2020 at 08:45:50AM +0100, Claudio Jeker wrote: > rt_ifa_add() and rt_ifa_del() have a major confusion when it comes to > rtlabelid (as in labels on a route) vs rtableid (as in routing table id). > Because of this 'ifconfig rtlabel XYZ' fails to add route labels to > the routing