Re: http(1) An alternate implementation for a subset of ftp(1)

2015-08-17 Thread Sunil Nimmagadda
On Mon, Aug 17, 2015 at 06:06:17PM +0200, Sebastien Marie wrote: Hi, I start reading your code, and I have a first remark. I see in main.c (at line 142 and next) that on redirection, you trust the server for the filename. I am not sure it is a good thing to do. If the user request

Re: http(1) An alternate implementation for a subset of ftp(1)

2015-08-17 Thread Sebastien Marie
Hi, I attached 3 patchs: - retry.patch: move name of output file outside the retry loop. Should keep the filename defined by user, instead of pike one from server. - spell.patch: correct a small spelling error - url-user.patch: a small change in url_parse() in order to copte with @

Re: http(1) An alternate implementation for a subset of ftp(1)

2015-08-17 Thread Sebastien Marie
Hi, I start reading your code, and I have a first remark. I see in main.c (at line 142 and next) that on redirection, you trust the server for the filename. I am not sure it is a good thing to do. If the user request 'http://www.example.com/a_filename' (without -o), the file created should be