Re: installboot(8): copy apple-boot to ESP

2022-11-21 Thread Klemens Nanni
On Mon, Nov 21, 2022 at 07:01:44PM +0100, Tobias Heider wrote: > + if (verbose) This block could use braces. > + fprintf(stderr, "%s %s to %s\n", > + (nowrite ? "would copy" : "copying"), > + src, dst); > +

Re: installboot(8): copy apple-boot to ESP

2022-11-21 Thread Klemens Nanni
On Mon, Nov 21, 2022 at 07:01:44PM +0100, Tobias Heider wrote: > On Mon, Nov 21, 2022 at 03:09:25PM +, Klemens Nanni wrote: > > On Mon, Nov 21, 2022 at 03:42:37PM +0100, Tobias Heider wrote: > > > Here is a more cleaned up version of the previous diff. I moved all the > > > firmware logic to

Re: installboot(8): copy apple-boot to ESP

2022-11-21 Thread Tobias Heider
On Mon, Nov 21, 2022 at 03:09:25PM +, Klemens Nanni wrote: > On Mon, Nov 21, 2022 at 03:42:37PM +0100, Tobias Heider wrote: > > Here is a more cleaned up version of the previous diff. I moved all the > > firmware logic to a new write_firmware() function. This should be easy > > to extend if

Re: installboot(8): copy apple-boot to ESP

2022-11-21 Thread Klemens Nanni
On Mon, Nov 21, 2022 at 03:42:37PM +0100, Tobias Heider wrote: > Here is a more cleaned up version of the previous diff. I moved all the > firmware logic to a new write_firmware() function. This should be easy > to extend if we decide to ship more firmware this way. This seems more tidy. > >

Re: installboot(8): copy apple-boot to ESP

2022-11-21 Thread Mark Kettenis
> Date: Mon, 21 Nov 2022 15:42:37 +0100 > From: Tobias Heider > > On Sat, Nov 19, 2022 at 08:27:18PM +0100, Tobias Heider wrote: > > On Sat, Nov 19, 2022 at 07:25:52PM +0100, Mark Kettenis wrote: > > > > Date: Sat, 19 Nov 2022 18:44:19 +0100 > > > > From: Tobias Heider > > > > > > > > On Sat,

Re: installboot(8): copy apple-boot to ESP

2022-11-21 Thread Tobias Heider
On Sat, Nov 19, 2022 at 08:27:18PM +0100, Tobias Heider wrote: > On Sat, Nov 19, 2022 at 07:25:52PM +0100, Mark Kettenis wrote: > > > Date: Sat, 19 Nov 2022 18:44:19 +0100 > > > From: Tobias Heider > > > > > > On Sat, Nov 19, 2022 at 06:33:51PM +0100, Mark Kettenis wrote: > > > > > Date: Sat, 19

Re: installboot(8): copy apple-boot to ESP

2022-11-19 Thread Tobias Heider
On Sat, Nov 19, 2022 at 07:25:52PM +0100, Mark Kettenis wrote: > > Date: Sat, 19 Nov 2022 18:44:19 +0100 > > From: Tobias Heider > > > > On Sat, Nov 19, 2022 at 06:33:51PM +0100, Mark Kettenis wrote: > > > > Date: Sat, 19 Nov 2022 18:26:36 +0100 > > > > From: Tobias Heider > > > > > > > > Here

Re: installboot(8): copy apple-boot to ESP

2022-11-19 Thread Mark Kettenis
> Date: Sat, 19 Nov 2022 18:44:19 +0100 > From: Tobias Heider > > On Sat, Nov 19, 2022 at 06:33:51PM +0100, Mark Kettenis wrote: > > > Date: Sat, 19 Nov 2022 18:26:36 +0100 > > > From: Tobias Heider > > > > > > Here is the promised last diff we need to enable Apple M* bootloader > > >

Re: installboot(8): copy apple-boot to ESP

2022-11-19 Thread Tobias Heider
On Sat, Nov 19, 2022 at 06:33:51PM +0100, Mark Kettenis wrote: > > Date: Sat, 19 Nov 2022 18:26:36 +0100 > > From: Tobias Heider > > > > Here is the promised last diff we need to enable Apple M* bootloader > > updates. > > > > With this, installboot(8) will pick up apple-boot.bin from the

Re: installboot(8): copy apple-boot to ESP

2022-11-19 Thread Mark Kettenis
> Date: Sat, 19 Nov 2022 18:26:36 +0100 > From: Tobias Heider > > Here is the promised last diff we need to enable Apple M* bootloader updates. > > With this, installboot(8) will pick up apple-boot.bin from the firmware > directory and writes it to $ESP/m1n1/boot.bin if both file and target >