Re: ksh: quote empties

2019-04-02 Thread Klemens Nanni
On Sun, Dec 30, 2018 at 02:43:37PM -0800, Philip Guenther wrote: > This thread was never resolved/committed. Looking again at the diffs, I > still think I prefer that we _not_ touch print_value_quoted(), as the > other callers all use the 'key=value' format and don't need special > handling of

Re: ksh: quote empties

2018-12-30 Thread Martijn Dekker
Op 30-12-18 om 23:43 schreef Philip Guenther: This thread was never resolved/committed. Looking again at the diffs, I still think I prefer that we_not_ touch print_value_quoted(), as the other callers all use the 'key=value' format and don't need special handling of empty values, [...] Not

Re: ksh: quote empties

2018-12-30 Thread Todd C. Miller
On Sun, 30 Dec 2018 14:43:37 -0800, Philip Guenther wrote: > This thread was never resolved/committed. Looking again at the diffs, I > still think I prefer that we _not_ touch print_value_quoted(), as the > other callers all use the 'key=value' format and don't need special > handling of

Re: ksh: quote empties

2018-12-30 Thread Philip Guenther
On Sun, 15 Apr 2018, Martijn Dekker wrote: > Op 15-04-18 om 03:41 schreef Philip Guenther: > > On Sun, 15 Apr 2018, Klemens Nanni wrote: > > > It also badly effects non-empty cases: > > ... > > > $ ./obj/ksh -c alias > > > autoload='' > > > functions='' > > > > Hah! The original diff i

Re: ksh: quote empties

2018-04-14 Thread Martijn Dekker
Op 15-04-18 om 04:09 schreef Martijn Dekker: Op 15-04-18 om 03:41 schreef Philip Guenther: On Sun, 15 Apr 2018, Klemens Nanni wrote: It also badly effects non-empty cases: ... $ ./obj/ksh -c alias autoload='' functions='' Hah!  The original diff i actually broken (it tests the

Re: ksh: quote empties

2018-04-14 Thread Martijn Dekker
Op 15-04-18 om 03:41 schreef Philip Guenther: On Sun, 15 Apr 2018, Klemens Nanni wrote: It also badly effects non-empty cases: ... $ ./obj/ksh -c alias autoload='' functions='' Hah! The original diff i actually broken (it tests the wrong variable) but I fixed that

Re: ksh: quote empties

2018-04-14 Thread Martijn Dekker
Op 15-04-18 om 03:03 schreef Philip Guenther: On Sun, 15 Apr 2018, Martijn Dekker wrote: $ ksh -c 'trap "" CONT; trap' trap -- CONT That is not "suitable for re-entry into the shell". Empty words must be quoted, or they disappear. Expected output: trap -- '' CONT Patch below. OK? That

Re: ksh: quote empties

2018-04-14 Thread Philip Guenther
On Sun, 15 Apr 2018, Klemens Nanni wrote: > It also badly effects non-empty cases: ... > $ ./obj/ksh -c alias > autoload='' > functions='' Hah! The original diff i actually broken (it tests the wrong variable) but I fixed that by accident when I manually made the diff in my

Re: ksh: quote empties

2018-04-14 Thread Klemens Nanni
On Sat, Apr 14, 2018 at 06:03:29PM -0700, Philip Guenther wrote: > On Sun, 15 Apr 2018, Martijn Dekker wrote: > > $ ksh -c 'trap "" CONT; trap' > > trap -- CONT > > > > That is not "suitable for re-entry into the shell". Empty words must be > > quoted, or they disappear. Expected output: > > >

Re: ksh: quote empties

2018-04-14 Thread Philip Guenther
On Sun, 15 Apr 2018, Martijn Dekker wrote: > $ ksh -c 'trap "" CONT; trap' > trap -- CONT > > That is not "suitable for re-entry into the shell". Empty words must be > quoted, or they disappear. Expected output: > > trap -- '' CONT > > Patch below. OK? That also changes the output of set,