Re: macppc: print uninorth/u3 revision number

2012-11-15 Thread Mike Belopuhov
On Thu, Nov 15, 2012 at 12:18 PM, Martin Pieuchot
mpieuc...@nolizard.org wrote:
 Simple diff to print UniNorth's revision so it becomes easy to know
 which AGP chipset people have without looking at the 'eeprom -p' output.

 before:
 memc0 at mainbus0: uni-n
 after:
 memc0 at mainbus0: uni-n rev 0xd2

 Ok?


looks good to me. ok



Re: macppc: print uninorth/u3 revision number

2012-11-15 Thread Mark Kettenis
 Date: Thu, 15 Nov 2012 12:18:06 +0100
 From: Martin Pieuchot mpieuc...@nolizard.org
 
 Simple diff to print UniNorth's revision so it becomes easy to know 
 which AGP chipset people have without looking at the 'eeprom -p' output.
 
 before:
   memc0 at mainbus0: uni-n
 after:
   memc0 at mainbus0: uni-n rev 0xd2
 
 Ok?

ok kettenis@

 Index: dev/uni_n.c
 ===
 RCS file: /cvs/src/sys/arch/macppc/dev/uni_n.c,v
 retrieving revision 1.15
 diff -u -p -r1.15 uni_n.c
 --- dev/uni_n.c   19 Jun 2006 22:41:35 -  1.15
 +++ dev/uni_n.c   15 Nov 2012 11:04:42 -
 @@ -73,18 +73,23 @@ memcmatch(struct device *parent, void *c
  void
  memcattach(struct device *parent, struct device *self, void *aux)
  {
 + struct memc_softc *sc = (struct memc_softc *)self;
   struct confargs *ca = aux;
 - int len;
 + u_int32_t rev;
   char name[64];
 - struct memc_softc *sc = (struct memc_softc *)self;
 + int len;
  
 - len = OF_getprop(ca-ca_node, name, name, sizeof name);
 + len = OF_getprop(ca-ca_node, name, name, sizeof(name));
   if (len  0)
   name[len] = 0;
  
 + len = OF_getprop(ca-ca_node, device-rev, rev, sizeof(rev));
 + if (len  0)
 + rev = 0;
 +
   uni_n_config(name, ca-ca_node);
  
 - printf (: %s\n, name);
 + printf (: %s rev 0x%x\n, name, rev);
  
   memc_attach_children(sc, ca-ca_node);
  }