Re: nanosleep.2: miscellaneous cleanup

2021-07-21 Thread Ingo Schwarze
Hi Scott, Scott Cheloha wrote on Wed, Jul 21, 2021 at 11:02:00AM -0500: [ EFAULT ] > Given deraadt@'s response I'm just going to leave the existing > language. Fine with me. > I guess I will need to dig into it a bit. Finding the text of the > really early documents, prior to SUSv2, is

Re: nanosleep.2: miscellaneous cleanup

2021-07-21 Thread Scott Cheloha
On Wed, Jul 21, 2021 at 04:00:51AM +0200, Ingo Schwarze wrote: > Hi Scott, > > Scott Cheloha wrote on Tue, Jul 20, 2021 at 05:20:16PM -0500: > > > The nanosleep.2 page could use some cleanup. Here's a bunch of fixes, > > rewrites, etc. > > > > I've included my notes on the changes below. I

Re: nanosleep.2: miscellaneous cleanup

2021-07-21 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Tue, Jul 20, 2021 at 08:14:20PM -0600: > Ingo Schwarze wrote: >> [EFAULT] foo points outside the process's allocated address space. >> >> But i don't really i like that. The word "allocated" makes me wonder >> because it sounds too much like malloc(3) for my

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Theo de Raadt
Scott Cheloha wrote: > I'm not wed to keeping all the examples. What if we merge examples 1 > and 2 and dumb the result down a bit? Are you teaching people how to fill a structure, how to perform a loop, or that they need to check errno? I don't see the point of having any example. Do we

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Theo de Raadt
> [EFAULT] foo points outside the process's allocated address space. > > But i don't really i like that. The word "allocated" makes me wonder > because it sounds too much like malloc(3) for my taste. > Usually, pointers to automatic and to static objects are acceptable, > too, and are those

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Ingo Schwarze
Hi Scott, Scott Cheloha wrote on Tue, Jul 20, 2021 at 05:20:16PM -0500: > The nanosleep.2 page could use some cleanup. Here's a bunch of fixes, > rewrites, etc. > > I've included my notes on the changes below. I have some (mostly > stylistic) questions in there, too. Thanks for explaining

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Scott Cheloha
On Tue, Jul 20, 2021 at 06:26:45PM -0600, Theo de Raadt wrote: > I think this is excessively verbose for such a simple function, especially > the addition of examples. > > There are many APIs which are hundreds of times more complicated which > don't have this level of detailing, and I would

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Theo de Raadt
I think this is excessively verbose for such a simple function, especially the addition of examples. There are many APIs which are hundreds of times more complicated which don't have this level of detailing, and I would argue such manual pages have the correct tone and complexity. It stops