Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Jeremie Courreges-Anglas
On Mon, Mar 25 2019, Remi Locherer wrote: [...] > This works and it makes sense to me. > > The log message is a bit lengthy compared to other log messages produced > by ospfd. Maybe something like this: "router-id changed: restart required" Yep, fine with me. > But the patch is also OK remi@

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Remi Locherer
On Mon, Mar 25, 2019 at 02:43:26PM +0100, Jeremie Courreges-Anglas wrote: > On Sun, Mar 24 2019, Mitchell Krome wrote: > > On 24/03/2019 7:23 am, Theo de Raadt wrote: > >> Sebastian Benoit wrote: > >> > >>> Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: > Was messing

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Sebastian Benoit
ok Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2019.03.25 14:43:26 +0100: > On Sun, Mar 24 2019, Mitchell Krome wrote: > > On 24/03/2019 7:23 am, Theo de Raadt wrote: > >> Sebastian Benoit wrote: > >> > >>> Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: > Was

Re: ospfd: Warn when the router ID changes during config reload

2019-03-25 Thread Jeremie Courreges-Anglas
On Sun, Mar 24 2019, Mitchell Krome wrote: > On 24/03/2019 7:23 am, Theo de Raadt wrote: >> Sebastian Benoit wrote: >> >>> Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: Was messing around with ospf and got myself into a situation where the router ID's were the

Re: ospfd: Warn when the router ID changes during config reload

2019-03-23 Thread Mitchell Krome
On 24/03/2019 7:23 am, Theo de Raadt wrote: > Sebastian Benoit wrote: > >> Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: >>> Was messing around with ospf and got myself into a situation where the >>> router ID's were the same on two boxes because I only did a reload on

Re: ospfd: Warn when the router ID changes during config reload

2019-03-23 Thread Theo de Raadt
Sebastian Benoit wrote: > Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: > > Was messing around with ospf and got myself into a situation where the > > router ID's were the same on two boxes because I only did a reload on > > one of them when I changed the loopback IP's. >

Re: ospfd: Warn when the router ID changes during config reload

2019-03-23 Thread Sebastian Benoit
Mitchell Krome(mitchellkr...@gmail.com) on 2019.03.23 20:27:17 +1000: > Was messing around with ospf and got myself into a situation where the > router ID's were the same on two boxes because I only did a reload on > one of them when I changed the loopback IP's. Thats sub optimal i believe... >