Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Sebastian Benoit
still ok Florian Obser(flor...@openbsd.org) on 2020.10.20 21:36:06 +0200: > On Tue, Oct 20, 2020 at 01:11:09PM -0600, Theo de Raadt wrote: > > I believe most of the new local variables you added in main, > > can instead be added in the flush loop you wrote, even if you > > have to instantiate

Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Florian Obser
On Tue, Oct 20, 2020 at 01:11:09PM -0600, Theo de Raadt wrote: > I believe most of the new local variables you added in main, > can instead be added in the flush loop you wrote, even if you > have to instantiate them. Or move it into a new function, > then it is even easier. their scope is just

Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Theo de Raadt
I believe most of the new local variables you added in main, can instead be added in the flush loop you wrote, even if you have to instantiate them. Or move it into a new function, then it is even easier. their scope is just too large... > @@ -240,6 +240,17 @@ void

Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Sebastian Benoit
i had observed this before with for i in `jot 5`;do ping6 -c 1 2001:4860:4860:: 1>/dev/null diff fixes the problem and looks correct to me. ok benno@ Florian Obser(flor...@openbsd.org) on 2020.10.20 18:39:58 +0200: > On Tue, Oct 20, 2020 at 04:07:41PM +0200, Martijn van Duren wrote: > >

Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Florian Obser
On Tue, Oct 20, 2020 at 04:07:41PM +0200, Martijn van Duren wrote: > When running: > /usr/local/libexec/nagios/check_ping -vv -6 -H -c 500,75% -w 250,50% > in a tight loop at some point I get the following output: > > CMD: /sbin/ping6 -n -c 5 > Output: PING (): 56 data bytes > Output: 64 bytes

Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Martijn van Duren
On Tue, 2020-10-20 at 15:59 +0200, Florian Obser wrote: > On Tue, Oct 20, 2020 at 03:46:19PM +0200, Martijn van Duren wrote: > > On Tue, 2020-10-20 at 15:19 +0200, Florian Obser wrote: > > > On Tue, Oct 20, 2020 at 09:20:32AM +0200, Martijn van Duren wrote: > > > > I have an icinga-instance

Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Florian Obser
On Tue, Oct 20, 2020 at 03:46:19PM +0200, Martijn van Duren wrote: > On Tue, 2020-10-20 at 15:19 +0200, Florian Obser wrote: > > On Tue, Oct 20, 2020 at 09:20:32AM +0200, Martijn van Duren wrote: > > > I have an icinga-instance running on openbsd.amsterdam. Here I found > > > that sometimes

Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Martijn van Duren
On Tue, 2020-10-20 at 15:19 +0200, Florian Obser wrote: > On Tue, Oct 20, 2020 at 09:20:32AM +0200, Martijn van Duren wrote: > > I have an icinga-instance running on openbsd.amsterdam. Here I found > > that sometimes check_ping from the monitoring-plugins package fails, > > because ping(8) sends

Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Florian Obser
On Tue, Oct 20, 2020 at 09:20:32AM +0200, Martijn van Duren wrote: > I have an icinga-instance running on openbsd.amsterdam. Here I found > that sometimes check_ping from the monitoring-plugins package fails, > because ping(8) sends "failed to get receiving hop limit", but still > receives all the