Re: powerpc64 BOOT kernel question

2023-09-23 Thread Klemens Nanni
On Sat, Sep 23, 2023 at 09:55:03AM -0600, Theo de Raadt wrote:
> Mark Kettenis  wrote:
> 
> > > Date: Fri, 22 Sep 2023 23:19:30 +
> > > From: Klemens Nanni 
> > > 
> > > Does the tiny kexec kernel actually need network, bio(4) or HID devices?
> > > octeon/BOOT does not have any of this.
> > 
> > Well, we do need the USB keyboard stuff to allow users to type at the
> > bootloader prompt no?  The USB mouse is clearly not needed, even on a
> > RAMDISK kernel.  That's an oversight.
> 
> Right.

Ah yes, rdboot does offer a boot prompt and I only accessed it via serial
console.

octeon BOOT lacks keyboard drivers, but perhaps that's fine as those
machines are mostly accessed by serial console alone, anyway?

> 
> > I'm not sure about trimming the pseudo-device stuff.  The fact that
> > you need that etherip line suggests that something is fishy.  I think
> > I would keep the loop line instead since that is what we do on the
> > floppy kernels for i386 and amd64.  The wsmux needs to be kept as well
> > of course.
> 
> It suggests you are choosing some random network-device, to pull in the
> network support.

This is what octeon's BOOT does.

> 
> 
> When you delete stuff out of the kernel configuration, you are heading
> towards configurations that *noone has ever tested*.
> 
> Do you really wish to be the first person to go there?  For a configuration
> where it is almost impossible to collect meaningful debug information?
> That doesn't seem sane.

No, I'd just like know better which options are used and which ones were
merely copied over.



Re: powerpc64 BOOT kernel question

2023-09-23 Thread Theo de Raadt
Mark Kettenis  wrote:

> > Date: Fri, 22 Sep 2023 23:19:30 +
> > From: Klemens Nanni 
> > 
> > Does the tiny kexec kernel actually need network, bio(4) or HID devices?
> > octeon/BOOT does not have any of this.
> 
> Well, we do need the USB keyboard stuff to allow users to type at the
> bootloader prompt no?  The USB mouse is clearly not needed, even on a
> RAMDISK kernel.  That's an oversight.

Right.

> I'm not sure about trimming the pseudo-device stuff.  The fact that
> you need that etherip line suggests that something is fishy.  I think
> I would keep the loop line instead since that is what we do on the
> floppy kernels for i386 and amd64.  The wsmux needs to be kept as well
> of course.

It suggests you are choosing some random network-device, to pull in the
network support.


When you delete stuff out of the kernel configuration, you are heading
towards configurations that *noone has ever tested*.

Do you really wish to be the first person to go there?  For a configuration
where it is almost impossible to collect meaningful debug information?
That doesn't seem sane.




Re: powerpc64 BOOT kernel question

2023-09-23 Thread Mark Kettenis
> Date: Fri, 22 Sep 2023 23:19:30 +
> From: Klemens Nanni 
> 
> Does the tiny kexec kernel actually need network, bio(4) or HID devices?
> octeon/BOOT does not have any of this.

Well, we do need the USB keyboard stuff to allow users to type at the
bootloader prompt no?  The USB mouse is clearly not needed, even on a
RAMDISK kernel.  That's an oversight.

I'm not sure about trimming the pseudo-device stuff.  The fact that
you need that etherip line suggests that something is fishy.  I think
I would keep the loop line instead since that is what we do on the
floppy kernels for i386 and amd64.  The wsmux needs to be kept as well
of course.

Dropping the INET6 and NFSCLIENT options seems safe.


> Looks like too much of powerpc64/RAMDISK remained, but I might be missing
> some obvious difference between these platforms.
> 
> The Raptor CS Blackbird used for the re-upgrade prevention diff still boots
> with this smaller config.
> 
> I'm just curious, this diff shows what I mean and doesn't fix anything.
> 
> Index: sys/arch/powerpc64/conf/BOOT
> ===
> RCS file: /cvs/src/sys/arch/powerpc64/conf/BOOT,v
> retrieving revision 1.9
> diff -u -p -r1.9 BOOT
> --- sys/arch/powerpc64/conf/BOOT  8 Jan 2022 05:40:19 -   1.9
> +++ sys/arch/powerpc64/conf/BOOT  22 Sep 2023 20:36:20 -
> @@ -15,9 +15,7 @@ option  MINIROOTSIZE=16384
>  option   FFS
>  option   FFS2
>  option   MSDOSFS
> -option   INET6
>  option   EXT2FS
> -option   NFSCLIENT
>  option   CRYPTO
>  
>  config   bsd root on rd0a swap on rd0b
> @@ -52,19 +50,8 @@ uk*at scsibus? # unknown S
>  # USB devices
>  uhub*at usb? # USB Hubs
>  uhub*at uhub?# USB Hubs
> -uhidev*  at uhub?# Human Interface Devices
> -uhid*at uhidev?  # USB generic HID support
> -ukbd*at uhidev?  # USB keyboard
> -wskbd*   at ukbd? mux 1
> -ums* at uhidev?  # USB mouse
> -wsmouse* at ums? mux 0
>  umass*   at uhub?# USB Mass Storage devices
>  
> -pseudo-deviceloop 1
> -pseudo-devicevlan
> -pseudo-devicetrunk
> -pseudo-devicebpfilter 1
> +pseudo-deviceetherip # pulls ether in kernel
>  pseudo-devicerd 1
> -pseudo-devicebio 1
>  pseudo-devicekexec
> -pseudo-devicewsmux 2
> 
> 



Re: powerpc64 BOOT kernel question

2023-09-22 Thread Theo de Raadt
Klemens Nanni  wrote:

> Does the tiny kexec kernel actually need network, bio(4) or HID devices?

I think you are playing with fire when you remove potential console devices.