Re: pppac(4): don't grab netlock within pppacioctl()

[YASUOKA Masahiko]

ok yasuoka

On Mon, 18 Jul 2022 13:50:37 +0300
Vitaliy Makkoveev  wrote:
> pipex(4) doesn't rely on netlock anymore.
> 
> Index: sys/net/if_pppx.c
> ===
> RCS file: /cvs/src/sys/net/if_pppx.c,v
> retrieving revision 1.119
> diff -u -p -r1.119 if_pppx.c
> --- sys/net/if_pppx.c 15 Jul 2022 22:56:13 -  1.119
> +++ sys/net/if_pppx.c 18 Jul 2022 10:48:31 -
> @@ -1161,7 +1161,6 @@ pppacioctl(dev_t dev, u_long cmd, caddr_
>   struct pppac_softc *sc = pppac_lookup(dev);
>   int error = 0;
>  
> - NET_LOCK();
>   switch (cmd) {
>   case FIONBIO:
>   break;
> @@ -1180,7 +1179,6 @@ pppacioctl(dev_t dev, u_long cmd, caddr_
>   error = pipex_ioctl(sc, cmd, data);
>   break;
>   }
> - NET_UNLOCK();
>  
>   return (error);
>  }
> 

Re: pppac(4): don't grab netlock within pppacioctl()

[Alexander Bluhm]

On Mon, Jul 18, 2022 at 01:50:37PM +0300, Vitaliy Makkoveev wrote:
> pipex(4) doesn't rely on netlock anymore.

OK bluhm@

> Index: sys/net/if_pppx.c
> ===
> RCS file: /cvs/src/sys/net/if_pppx.c,v
> retrieving revision 1.119
> diff -u -p -r1.119 if_pppx.c
> --- sys/net/if_pppx.c 15 Jul 2022 22:56:13 -  1.119
> +++ sys/net/if_pppx.c 18 Jul 2022 10:48:31 -
> @@ -1161,7 +1161,6 @@ pppacioctl(dev_t dev, u_long cmd, caddr_
>   struct pppac_softc *sc = pppac_lookup(dev);
>   int error = 0;
>  
> - NET_LOCK();
>   switch (cmd) {
>   case FIONBIO:
>   break;
> @@ -1180,7 +1179,6 @@ pppacioctl(dev_t dev, u_long cmd, caddr_
>   error = pipex_ioctl(sc, cmd, data);
>   break;
>   }
> - NET_UNLOCK();
>  
>   return (error);
>  }