Re: relayd websocket

2019-05-08 Thread Sebastian Benoit
ok benno@ Reyk Floeter(r...@openbsd.org) on 2019.05.08 20:35:46 +0200: > On Wed, May 08, 2019 at 07:07:43PM +0200, Reyk Floeter wrote: > > On Wed, May 08, 2019 at 06:26:45PM +0200, Reyk Floeter wrote: > > > On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: > > > > Rivo

Re: relayd websocket

2019-05-08 Thread Rivo Nurges
Hi! Seems to work fine. Rivo On 2019-05-08 21:37, Reyk Floeter wrote: > On Wed, May 08, 2019 at 07:07:43PM +0200, Reyk Floeter wrote: >> On Wed, May 08, 2019 at 06:26:45PM +0200, Reyk Floeter wrote: >>> On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: Rivo

Re: relayd websocket

2019-05-08 Thread Reyk Floeter
On Wed, May 08, 2019 at 07:07:43PM +0200, Reyk Floeter wrote: > On Wed, May 08, 2019 at 06:26:45PM +0200, Reyk Floeter wrote: > > On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: > > > Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > > > > Hi! > > > > > > > > On

Re: relayd websocket

2019-05-08 Thread Reyk Floeter
On Wed, May 08, 2019 at 06:26:45PM +0200, Reyk Floeter wrote: > On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: > > Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > > > Hi! > > > > > > On 3/5/19 10:36 PM, Claudio Jeker wrote: > > > > I guess that this would need

Re: relayd websocket

2019-05-08 Thread Reyk Floeter
On Wed, Mar 06, 2019 at 05:36:32PM +0100, Sebastian Benoit wrote: > Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > > Hi! > > > > On 3/5/19 10:36 PM, Claudio Jeker wrote: > > > I guess that this would need strcasestr() instead of strcasecmp(), since > > > you > > > are looking

Re: relayd websocket

2019-05-08 Thread Rivo Nurges
Hi! Anyone? Rivo On 2019-03-12 21:50, Rivo Nurges wrote: > Hi! > > Bump... > > Rivo > > On 3/6/19 10:57 PM, Rivo Nurges wrote: >> Hi! >> >> >> On 3/6/19 10:20 PM, Rivo Nurges wrote: >>> On 3/6/19 6:36 PM, Sebastian Benoit wrote: > Does something like this make sense? i think

Re: relayd websocket

2019-03-12 Thread Rivo Nurges
Hi! Bump... Rivo On 3/6/19 10:57 PM, Rivo Nurges wrote: > Hi! > > > On 3/6/19 10:20 PM, Rivo Nurges wrote: >> On 3/6/19 6:36 PM, Sebastian Benoit wrote: Does something like this make sense? >>> >>> i think the seperator list needs to include '\t' >>> because

Re: relayd websocket

2019-03-06 Thread Rivo Nurges
Hi! On 3/6/19 10:20 PM, Rivo Nurges wrote: > On 3/6/19 6:36 PM, Sebastian Benoit wrote: >>> Does something like this make sense? >> >> i think the seperator list needs to include '\t' >> because https://tools.ietf.org/html/rfc7230#appendix-B includes HTAB. >> >> And i dont think you can mix ","

Re: relayd websocket

2019-03-06 Thread Rivo Nurges
On 3/6/19 6:36 PM, Sebastian Benoit wrote: >> Does something like this make sense? > > i think the seperator list needs to include '\t' > because https://tools.ietf.org/html/rfc7230#appendix-B includes HTAB. > > And i dont think you can mix "," with " \t" seperators, > because otherwise "Foo

Re: relayd websocket

2019-03-06 Thread Sebastian Benoit
Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > Hi! > > On 3/5/19 10:36 PM, Claudio Jeker wrote: > > I guess that this would need strcasestr() instead of strcasecmp(), since you > > are looking for the substring "Upgrade" in value. Maybe more is needed if > > we want to be sure

Re: relayd websocket

2019-03-05 Thread Rivo Nurges
Hi! On 3/5/19 10:36 PM, Claudio Jeker wrote: > I guess that this would need strcasestr() instead of strcasecmp(), since you > are looking for the substring "Upgrade" in value. Maybe more is needed if > we want to be sure that 'Connection: Upgrade-maybe' does not match. You are correct about

Re: relayd websocket

2019-03-05 Thread Claudio Jeker
On Tue, Mar 05, 2019 at 04:21:30PM +, Rivo Nurges wrote: > Hi! > > RFC 6455 4.2.1 states: > 4. A |Connection| header field that *includes* the token "Upgrade", > treated as an ASCII case-insensitive value. > > In my test case Firefox sends: Connection: keep-alive, Upgrade > > Relayd