Re: try to bundle multiple packets on an ifq before sending

2017-11-13 Thread Martin Pieuchot
On 13/11/17(Mon) 20:28, David Gwynne wrote: > > > On 13 Nov 2017, at 5:37 pm, Martin Pieuchot wrote: > > > > On 13/11/17(Mon) 10:56, David Gwynne wrote: > >> On Sun, Nov 12, 2017 at 02:45:05PM +0100, Martin Pieuchot wrote: > >>> [...] > >>> We're currently using net_tq() to

Re: try to bundle multiple packets on an ifq before sending

2017-11-13 Thread David Gwynne
> On 13 Nov 2017, at 5:37 pm, Martin Pieuchot wrote: > > On 13/11/17(Mon) 10:56, David Gwynne wrote: >> On Sun, Nov 12, 2017 at 02:45:05PM +0100, Martin Pieuchot wrote: >>> [...] >>> We're currently using net_tq() to distribute load for incoming packets. >>> So I believe you

Re: try to bundle multiple packets on an ifq before sending

2017-11-12 Thread Martin Pieuchot
On 13/11/17(Mon) 10:56, David Gwynne wrote: > On Sun, Nov 12, 2017 at 02:45:05PM +0100, Martin Pieuchot wrote: > > [...] > > We're currently using net_tq() to distribute load for incoming packets. > > So I believe you should schedule the task on the current taskq or the > > first one if coming

Re: try to bundle multiple packets on an ifq before sending

2017-11-12 Thread David Gwynne
On Sun, Nov 12, 2017 at 02:45:05PM +0100, Martin Pieuchot wrote: > On 10/11/17(Fri) 10:58, David Gwynne wrote: > > this makes ifq_start try to wait for 4 packets before calling > > if->if_qstart. > > So you're adding back the IFXF_TXREADY mechanism that you removed in > 2015 in r1.418. At that

Re: try to bundle multiple packets on an ifq before sending

2017-11-12 Thread Martin Pieuchot
On 10/11/17(Fri) 10:58, David Gwynne wrote: > this makes ifq_start try to wait for 4 packets before calling > if->if_qstart. So you're adding back the IFXF_TXREADY mechanism that you removed in 2015 in r1.418. At that time we couldn't clearly see how to make it MP-safe. > this is based on work

Re: try to bundle multiple packets on an ifq before sending

2017-11-10 Thread Claudio Jeker
On Fri, Nov 10, 2017 at 10:58:54AM +1000, David Gwynne wrote: > this makes ifq_start try to wait for 4 packets before calling > if->if_qstart. > > this is based on work sephe did in dragonflybsd, and described in > a comment in their sys/net/if.c. there's a link to it here: >

Re: try to bundle multiple packets on an ifq before sending

2017-11-10 Thread Hrvoje Popovski
On 10.11.2017. 1:58, David Gwynne wrote: > this makes ifq_start try to wait for 4 packets before calling > if->if_qstart. > > this is based on work sephe did in dragonflybsd, and described in > a comment in their sys/net/if.c. there's a link to it here: >