Re: ts(1): make timespec-handling code more obvious

2022-07-06 Thread Claudio Jeker
On Tue, Jul 05, 2022 at 07:04:49AM -0500, Scott Cheloha wrote: > On Tue, Jul 05, 2022 at 11:53:26AM +0200, Claudio Jeker wrote: > > On Tue, Jul 05, 2022 at 11:34:21AM +, Job Snijders wrote: > > > On Tue, Jul 05, 2022 at 11:08:13AM +0200, Claudio Jeker wrote: > > > > On Mon, Jul 04, 2022 at

Re: ts(1): make timespec-handling code more obvious

2022-07-05 Thread Scott Cheloha
On Tue, Jul 05, 2022 at 11:53:26AM +0200, Claudio Jeker wrote: > On Tue, Jul 05, 2022 at 11:34:21AM +, Job Snijders wrote: > > On Tue, Jul 05, 2022 at 11:08:13AM +0200, Claudio Jeker wrote: > > > On Mon, Jul 04, 2022 at 05:10:05PM -0500, Scott Cheloha wrote: > > > > On Mon, Jul 04, 2022 at

Re: ts(1): make timespec-handling code more obvious

2022-07-05 Thread Job Snijders
> > this changeset too. > > Ah right, we print us not ms. > > > nitpick: the changeset doesn't apply cleanly: > > Forgot to update that tree :) > > Updated diff below OK job@

Re: ts(1): make timespec-handling code more obvious

2022-07-05 Thread Claudio Jeker
On Tue, Jul 05, 2022 at 11:34:21AM +, Job Snijders wrote: > On Tue, Jul 05, 2022 at 11:08:13AM +0200, Claudio Jeker wrote: > > On Mon, Jul 04, 2022 at 05:10:05PM -0500, Scott Cheloha wrote: > > > On Mon, Jul 04, 2022 at 11:15:24PM +0200, Claudio Jeker wrote: > > > > On Mon, Jul 04, 2022 at

Re: ts(1): make timespec-handling code more obvious

2022-07-05 Thread Job Snijders
On Tue, Jul 05, 2022 at 11:08:13AM +0200, Claudio Jeker wrote: > On Mon, Jul 04, 2022 at 05:10:05PM -0500, Scott Cheloha wrote: > > On Mon, Jul 04, 2022 at 11:15:24PM +0200, Claudio Jeker wrote: > > > On Mon, Jul 04, 2022 at 01:28:12PM -0500, Scott Cheloha wrote: > > > > Hi, > > > > > > > >

Re: ts(1): make timespec-handling code more obvious

2022-07-05 Thread Claudio Jeker
On Mon, Jul 04, 2022 at 05:10:05PM -0500, Scott Cheloha wrote: > On Mon, Jul 04, 2022 at 11:15:24PM +0200, Claudio Jeker wrote: > > On Mon, Jul 04, 2022 at 01:28:12PM -0500, Scott Cheloha wrote: > > > Hi, > > > > > > Couple things: > > > > > > [...] > > > > I don't like the introduction of all

Re: ts(1): make timespec-handling code more obvious

2022-07-04 Thread Scott Cheloha
On Mon, Jul 04, 2022 at 11:15:24PM +0200, Claudio Jeker wrote: > On Mon, Jul 04, 2022 at 01:28:12PM -0500, Scott Cheloha wrote: > > Hi, > > > > Couple things: > > > > [...] > > I don't like the introduction of all these local variables that are just > hard to follow and need extra code pathes.

Re: ts(1): make timespec-handling code more obvious

2022-07-04 Thread Claudio Jeker
On Mon, Jul 04, 2022 at 01:28:12PM -0500, Scott Cheloha wrote: > Hi, > > Couple things: > > - Use additional timespec variables to make our intent more obvious. > > Add "elapsed", "utc_offset", and "utc_start". > > "roff" is a confusing name, "utc_offset" is better. > > Yes, I know the