Re: two minor carp and pfsync fixes

2011-06-22 Thread Stefan Rinkes
On Tue, Jun 21, 2011 at 9:42 PM, Tobias Weingartner weing...@tepid.org wrote: On Tue, Jun 21, 2011 at 11:52 AM, Stefan Rinkes stefan.rin...@googlemail.com wrote: while playing around with carp and pfsync I spotted two minor bugs. 1. Not all pfstate flags are synced, cause pfsync uses

Re: two minor carp and pfsync fixes

2011-06-22 Thread Otto Moerbeek
On Wed, Jun 22, 2011 at 09:37:58AM +0200, Stefan Rinkes wrote: On Tue, Jun 21, 2011 at 9:42 PM, Tobias Weingartner weing...@tepid.org wrote: On Tue, Jun 21, 2011 at 11:52 AM, Stefan Rinkes stefan.rin...@googlemail.com wrote: while playing around with carp and pfsync I spotted two

Re: two minor carp and pfsync fixes

2011-06-22 Thread Tobias Weingartner
I'm sure you did. Did you test it with one patched and one not? -Toby. On Wed, Jun 22, 2011 at 1:37 AM, Stefan Rinkes stefan.rin...@googlemail.com wrote: On Tue, Jun 21, 2011 at 9:42 PM, Tobias Weingartner weing...@tepid.org wrote: On Tue, Jun 21, 2011 at 11:52 AM, Stefan Rinkes

Re: two minor carp and pfsync fixes

2011-06-22 Thread David Gwynne
On 22/06/2011, at 3:52 AM, Stefan Rinkes wrote: Hi, while playing around with carp and pfsync I spotted two minor bugs. 1. Not all pfstate flags are synced, cause pfsync uses u_int8_t, while pf uses u_int16_t for state_flags. Currently that means PFSTATE_SCRUB_TCP flags don't

Re: two minor carp and pfsync fixes

2011-06-21 Thread Tobias Weingartner
On Tue, Jun 21, 2011 at 11:52 AM, Stefan Rinkes stefan.rin...@googlemail.com wrote: while playing around with carp and pfsync I spotted two minor bugs. 1. Not all pfstate flags are synced, cause pfsync uses u_int8_t, while pf uses u_int16_t for state_flags. Currently that means