Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Florian Obser
usr.sbin, missing prototypes: diff --git usr.sbin/mrouted/defs.h usr.sbin/mrouted/defs.h index 4c9224a..45b060f 100644 --- usr.sbin/mrouted/defs.h +++ usr.sbin/mrouted/defs.h @@ -209,6 +209,7 @@ extern void accept_leave_message(u_int32_t src, u_int32_t dst,

Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Florian Obser
usr.sbin, fix bind configure: Carefully checked that config.h and generated Makefiles don't change. diff --git usr.sbin/bind/configure usr.sbin/bind/configure index 6e280ad..db02979 100644 --- usr.sbin/bind/configure +++ usr.sbin/bind/configure @@ -4596,6 +4596,8 @@ cat confdefs.h

Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Florian Obser
usr.sbin, fix nsd/unbound configure carefully checked that config.h and generated Makefiles don't change. need for _XOPEN_VERSION pointed out by guenther@ diff --git usr.sbin/nsd/configure usr.sbin/nsd/configure index d2d28c1..c2a40e8 100644 --- usr.sbin/nsd/configure +++ usr.sbin/nsd/configure

Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Florian Obser
usr.sbin; enable -Werror-implicit-function-declaration: This has currently no effect on subdirs using Makefile.bsd-wrapper (bind, nginx, nsd, unbound). This is beeing worked on. With a workaround they have been tested and with the previous diffs are clean. diff --git usr.sbin/Makefile.inc

Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Ted Unangst
On Fri, Jul 11, 2014 at 14:09, Florian Obser wrote: usr.sbin, make sure subdirs of subdirs see usr.sbin/Makefile.inc: Does the same thing as lpr/pac and pppd/pppstats. I have no idea if this is the right way, but it seems to work. Cluebats welcome. I think maybe it would be nicer to create a

Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Marc Espie
On Fri, Jul 11, 2014 at 10:27:57AM -0400, Ted Unangst wrote: On Fri, Jul 11, 2014 at 14:09, Florian Obser wrote: usr.sbin, make sure subdirs of subdirs see usr.sbin/Makefile.inc: Does the same thing as lpr/pac and pppd/pppstats. I have no idea if this is the right way, but it seems to

Re: using -Werror-implicit-function-declaration

2014-07-10 Thread Florian Obser
/sbin: diff --git sbin/Makefile.inc sbin/Makefile.inc index 1b14860..92ca312 100644 --- sbin/Makefile.inc +++ sbin/Makefile.inc @@ -2,3 +2,4 @@ BINDIR?= /sbin LDSTATIC= ${STATIC} +CFLAGS+= -Werror-implicit-function-declaration diff --git sbin/disklabel/editor.c