Re: wscons(4): set WS_KERNEL_COLATTR to WSATTR_HILIT in vt100 emulation
I see no reason to change this. The first complaint in 25 years sounds like "personal preference" or "desire to push a change". > Currently, output originating from the kernel is displayed using > WSCOL_WHITE on WSCOL_BLUE, which translates to NORMAL_WHITE on > NORMAL_BLUE. > > When booting in BIOS mode, NORMAL_WHITE is 0xaa in text mode > (which is very hard to read on a blue backgroud), and when framebuffer > attaches, NORMAL_WHITE becomes 0xc7c7c7. > > The proposed change makes text display using HILITE_WHITE, which > is 0xff in both text mode and framebuffer console. > > I've been running with this diff for a while now and find kernel > messages easier to read this way, especially in text mode. > > Comments? OK? > > Index: sys/dev/wscons/wsemul_vt100.c > === > RCS file: /cvs/src/sys/dev/wscons/wsemul_vt100.c,v > retrieving revision 1.36 > diff -u -p -r1.36 wsemul_vt100.c > --- sys/dev/wscons/wsemul_vt100.c 10 Aug 2017 09:12:32 - 1.36 > +++ sys/dev/wscons/wsemul_vt100.c 12 Aug 2017 14:42:28 - > @@ -171,7 +171,7 @@ wsemul_vt100_cnattach(const struct wsscr > #define WS_KERNEL_BG WSCOL_BLUE > #endif > #ifndef WS_KERNEL_COLATTR > -#define WS_KERNEL_COLATTR 0 > +#define WS_KERNEL_COLATTR WSATTR_HILIT > #endif > #ifndef WS_KERNEL_MONOATTR > #define WS_KERNEL_MONOATTR 0 >
Re: wscons(4): set WS_KERNEL_COLATTR to WSATTR_HILIT in vt100 emulation
> Date: Sat, 12 Aug 2017 17:06:18 +0200 > From: Frederic Cambus > > Hi tech@, > > Currently, output originating from the kernel is displayed using > WSCOL_WHITE on WSCOL_BLUE, which translates to NORMAL_WHITE on > NORMAL_BLUE. > > When booting in BIOS mode, NORMAL_WHITE is 0xaa in text mode > (which is very hard to read on a blue backgroud), and when framebuffer > attaches, NORMAL_WHITE becomes 0xc7c7c7. > > The proposed change makes text display using HILITE_WHITE, which > is 0xff in both text mode and framebuffer console. > > I've been running with this diff for a while now and find kernel > messages easier to read this way, especially in text mode. > > Comments? OK? Way too bright if you're in a dark environment IMHO. Even the 0xc7c7c7 is a bit on the bright side, and I don't really consider the 0xaa in BIOS mode to be a real problem. > Index: sys/dev/wscons/wsemul_vt100.c > === > RCS file: /cvs/src/sys/dev/wscons/wsemul_vt100.c,v > retrieving revision 1.36 > diff -u -p -r1.36 wsemul_vt100.c > --- sys/dev/wscons/wsemul_vt100.c 10 Aug 2017 09:12:32 - 1.36 > +++ sys/dev/wscons/wsemul_vt100.c 12 Aug 2017 14:42:28 - > @@ -171,7 +171,7 @@ wsemul_vt100_cnattach(const struct wsscr > #define WS_KERNEL_BG WSCOL_BLUE > #endif > #ifndef WS_KERNEL_COLATTR > -#define WS_KERNEL_COLATTR 0 > +#define WS_KERNEL_COLATTR WSATTR_HILIT > #endif > #ifndef WS_KERNEL_MONOATTR > #define WS_KERNEL_MONOATTR 0 > >
