Re: Stop ping telling world its pid

2018-04-12 Thread Miod Vallat
> what we need is an eventually consistent 16 bit number microservice message > bus that all ping processes can subscribe to. And it should be available as early as possible during boot, so I think its place is in init(8).

Re: Stop ping telling world its pid

2018-04-12 Thread Ted Unangst
Job Snijders wrote: > I’m not great at math, with a 16 bit random value, wouldn’t we start > running into ID collisions around 256 concurrent ping processes? Perhaps > that already is the case today and this patch does nothing to improve that, > but also doesn’t make it worse. what we need is an e

Re: Stop ping telling world its pid

2018-04-11 Thread Job Snijders
When things arrive out of sequence, that usually is of special interest to network operator people. Not sure the sequence field can easily be overloaded to increase “validity”. I’m not great at math, with a 16 bit random value, wouldn’t we start running into ID collisions around 256 concurrent pi

Re: Stop ping telling world its pid

2018-04-11 Thread Theo de Raadt
"The standard convention of using the locally-significant PID should be fine." Jimmy Hess, 2018 A whole bunch of protocols got holed because of that attitude.

Re: Stop ping telling world its pid

2018-04-11 Thread Theo de Raadt
We never claimed that OpenBSD ping conforms to the 'High Availability ICMP ECHO' RFC. Jimmy Hess wrote: > On Tue, Apr 10, 2018 at 3:11 PM, Vadim Zhukov wrote: > > > While working on home job for students, I've come across two > > questionable thingies in ping.c: > > > > 1. It sends process PID

Re: Stop ping telling world its pid

2018-04-11 Thread Jimmy Hess
On Tue, Apr 10, 2018 at 3:11 PM, Vadim Zhukov wrote: > While working on home job for students, I've come across two > questionable thingies in ping.c: > > 1. It sends process PID (well, last 16 bits) to the network. >Maybe I'm a bit paranoid, but this looks like bad idea for me. Well, you ne

Re: Stop ping telling world its pid

2018-04-11 Thread Florian Obser
On Tue, Apr 10, 2018 at 11:11:39PM +0300, Vadim Zhukov wrote: > Hi all! > > While working on home job for students, I've come across two > questionable thingies in ping.c: > > 1. It sends process PID (well, last 16 bits) to the network. >Maybe I'm a bit paranoid, but this looks like bad idea

Stop ping telling world its pid

2018-04-10 Thread Vadim Zhukov
Hi all! While working on home job for students, I've come across two questionable thingies in ping.c: 1. It sends process PID (well, last 16 bits) to the network. Maybe I'm a bit paranoid, but this looks like bad idea for me. I understand that this worked good when PIDs were 16-bit limited,