Jeremie Courreges-Anglas wrote:
> On Wed, Jan 03 2018, Carlos Cardenas wrote:
> > Howdy.
> >
> > Attached is a patch to address a TOCTOU issue with checking to
> > ensure disks are regular files, reported by jca@ .
> >
> > Comments? Ok?
>
> A bit late, but ok.
>
> While here, if the S_ISREG ch
On Fri, Jan 05, 2018 at 08:26:21AM +0100, Jeremie Courreges-Anglas wrote:
> On Wed, Jan 03 2018, Carlos Cardenas wrote:
> > Howdy.
> >
> > Attached is a patch to address a TOCTOU issue with checking to
> > ensure disks are regular files, reported by jca@ .
> >
> > Comments? Ok?
>
> A bit late, bu
On Wed, Jan 03 2018, Carlos Cardenas wrote:
> Howdy.
>
> Attached is a patch to address a TOCTOU issue with checking to
> ensure disks are regular files, reported by jca@ .
>
> Comments? Ok?
A bit late, but ok.
While here, if the S_ISREG check fails there is no meaningful errno to
report.
ok?
On Thu, Jan 04, 2018 at 07:14:54AM -0800, Carlos Cardenas wrote:
> Mike Larkin wrote:
>
> > On Wed, Jan 03, 2018 at 08:03:56PM -0800, Carlos Cardenas wrote:
> > > Howdy.
> > >
> > > Attached is a patch to address a TOCTOU issue with checking to
> > > ensure disks are regular files, reported by j
Mike Larkin wrote:
> On Wed, Jan 03, 2018 at 08:03:56PM -0800, Carlos Cardenas wrote:
> > Howdy.
> >
> > Attached is a patch to address a TOCTOU issue with checking to
> > ensure disks are regular files, reported by jca@ .
> >
> > Comments? Ok?
> >
> > +--+
> > Carlos
>
> > Index: config.c
>
On Wed, Jan 03, 2018 at 08:03:56PM -0800, Carlos Cardenas wrote:
> Howdy.
>
> Attached is a patch to address a TOCTOU issue with checking to
> ensure disks are regular files, reported by jca@ .
>
> Comments? Ok?
>
> +--+
> Carlos
> Index: config.c
> =
Howdy.
Attached is a patch to address a TOCTOU issue with checking to
ensure disks are regular files, reported by jca@ .
Comments? Ok?
+--+
Carlos
Index: config.c
===
RCS file: /home/los/cvs/src/usr.sbin/vmd/config.c,v
retrieving re