Re: em: minimum ethernet frame size

2018-02-13 Thread Michele Curti
On Fri, Feb 09, 2018 at 03:40:13PM +0100, Martin Pieuchot wrote: > On 02/02/18(Fri) 12:18, Michele Curti wrote: > > Hi, > > in sys/dev/pci/if_em.c at line 469 there is: > > sc->hw.min_frame_size = > > ETHER_MIN_LEN + ETHER_CRC_LEN; > > > > But ETHER_MIN_LEN already includes the CRC siz

Re: em: minimum ethernet frame size

2018-02-09 Thread Martin Pieuchot
On 02/02/18(Fri) 12:18, Michele Curti wrote: > Hi, > in sys/dev/pci/if_em.c at line 469 there is: > sc->hw.min_frame_size = > ETHER_MIN_LEN + ETHER_CRC_LEN; > > But ETHER_MIN_LEN already includes the CRC size: > #define ETHER_MIN_LEN 64 /* Minimum frame length, CRC included

Re: em: minimum ethernet frame size

2018-02-02 Thread Chris Cappuccio
sc->hw.min_frame_size is only used for TBI mode, which is only available on the 82543 according to em_set_media_type() You'd need to carefully analyze how the TBI_ACCEPT macro is used to see what's right here. The macro even seems to assume that the vlan tag size might be part of min_frame_size.

em: minimum ethernet frame size

2018-02-02 Thread Michele Curti
Hi, in sys/dev/pci/if_em.c at line 469 there is: sc->hw.min_frame_size = ETHER_MIN_LEN + ETHER_CRC_LEN; But ETHER_MIN_LEN already includes the CRC size: #define ETHER_MIN_LEN 64 /* Minimum frame length, CRC included */ In revision 1.41 the code changed in this way: