Re: netstart: SOII: fix comment, print step with -n

2022-10-26 Thread Klemens Nanni
On Mon, Oct 24, 2022 at 07:01:02PM +, Klemens Nanni wrote:
> IPv6LL no longer uses SOII (ifconfig(8) `soii' description got fixed).

Relevant commit:

sys/netinet6/in6_ifattach.c revision 1.114
date: 2019/08/21 15:32:18;  author: florian;  state: Exp;  lines: +2 
-83;
Remove support for semantically opace interface identifiers (RFC 7217)
for IPv6 link local addresses.

> Don't ignore this step in dry-runs.  In analogy to how we print
>   { ifconfig trunk0 || ifconfig trunk0 create; }
> 
> the file check could be deferred and printed as well, i.e.
>   [[ -f /etc/soii.key ]] && sysctl ...
> 
> Better print the check?
> Feedback? Objection? OK?

Here's the diff that prints the check, which is probably better.

Index: netstart
===
RCS file: /cvs/src/etc/netstart,v
retrieving revision 1.222
diff -u -p -r1.222 netstart
--- netstart24 Oct 2022 20:51:07 -  1.222
+++ netstart26 Oct 2022 17:29:45 -
@@ -323,9 +323,13 @@ done
 shift $((OPTIND-1))
 
 # Load key material for the generation of IPv6 Semantically Opaque Interface
-# Identifiers (SOII) used for link local and SLAAC addresses.
-$PRINT_ONLY || [[ ! -f /etc/soii.key ]] ||
-   sysctl -q "net.inet6.ip6.soiikey=$(

netstart: SOII: fix comment, print step with -n

2022-10-24 Thread Klemens Nanni
IPv6LL no longer uses SOII (ifconfig(8) `soii' description got fixed).

Don't ignore this step in dry-runs.  In analogy to how we print
{ ifconfig trunk0 || ifconfig trunk0 create; }

the file check could be deferred and printed as well, i.e.
[[ -f /etc/soii.key ]] && sysctl ...

Better print the check?
Feedback? Objection? OK?

Index: netstart
===
RCS file: /cvs/src/etc/netstart,v
retrieving revision 1.220
diff -u -p -r1.220 netstart
--- netstart21 Oct 2022 12:04:51 -  1.220
+++ netstart24 Oct 2022 18:55:40 -
@@ -323,9 +323,14 @@ done
 shift $((OPTIND-1))
 
 # Load key material for the generation of IPv6 Semantically Opaque Interface
-# Identifiers (SOII) used for link local and SLAAC addresses.
-$PRINT_ONLY || [[ ! -f /etc/soii.key ]] ||
-   sysctl -q "net.inet6.ip6.soiikey=$(