Re: patch: properly check NULL return values

2014-11-26 Thread Tobias Stoeckmann
Hi, turns out that there are a few more bad savestr calls even inside of pch.c. Some of the code pathes are quite obvious that a NULL return value would lead to a null pointer dereference, others would last longer before dereferencing. Carefully reviewing the savestr calls, the rule of thumb

patch: properly check NULL return values

2014-11-17 Thread Tobias Stoeckmann
Hi, savestr is a function very similar to strdup. If it runs into an out of memory condition, its behavior depends on the current status of the program. If patch is in plan a mode, it will set an out_of_memory flag, returns NULL and patch will try later on with plan b again. If it is in plan b,