Re: unwind(8): disable logging to syslog from libunbound

2021-01-25 Thread Klemens Nanni
On Mon, Jan 25, 2021 at 05:08:48PM +0100, Florian Obser wrote:
> We are not getting anything useful for us out of it and it can be
> quite noisy when we are missing IPv4 or IPv6 addresses as pointed out
> by kn@.
> It is still available when logging to stderr when running with -d.
OK kn

> Also shown a revert for a local diff we are carrying, I'll commit that
> seperately.
Thanks.



unwind(8): disable logging to syslog from libunbound

2021-01-25 Thread Florian Obser
We are not getting anything useful for us out of it and it can be
quite noisy when we are missing IPv4 or IPv6 addresses as pointed out
by kn@.
It is still available when logging to stderr when running with -d.

OK?

Also shown a revert for a local diff we are carrying, I'll commit that
seperately.

diff --git libunbound/util/log.c libunbound/util/log.c
index e8e987963c5..dfbb2334994 100644
--- libunbound/util/log.c
+++ libunbound/util/log.c
@@ -109,20 +109,16 @@ log_init(const char* filename, int use_syslog, const 
char* chrootdir)
fclose(cl);
}
 #ifdef HAVE_SYSLOG_H
-#if 0  /* unwind handles syslog for us */
if(logging_to_syslog) {
closelog();
logging_to_syslog = 0;
}
-#endif
if(use_syslog) {
/* do not delay opening until first write, because we may
 * chroot and no longer be able to access dev/log and so on */
/* the facility is LOG_DAEMON by default, but
 * --with-syslog-facility=LOCAL[0-7] can override it */
-#if 0  /* unwind handles syslog for us */
openlog(ident, LOG_NDELAY, UB_SYSLOG_FACILITY);
-#endif
logging_to_syslog = 1;
lock_basic_unlock(_lock);
return;
diff --git resolver.c resolver.c
index e800d38280a..a3521e8025f 100644
--- resolver.c
+++ resolver.c
@@ -498,7 +498,7 @@ resolver_dispatch_frontend(int fd, short event, void *bula)
"%lu", __func__,
IMSG_DATA_SIZE(imsg));
memcpy(, imsg.data, sizeof(verbose));
-   if ((log_getverbose() & OPT_VERBOSE3)
+   if (log_getdebug() && (log_getverbose() & OPT_VERBOSE3)
!= (verbose & OPT_VERBOSE3))
restart_ub_resolvers();
log_setverbose(verbose);
@@ -1257,13 +1257,14 @@ create_resolver(enum uw_resolver_type type)
 
if (!log_getdebug()) {
if((err = ub_ctx_set_option(res->ctx, "use-syslog:",
-   "yes")) != 0) {
+   "no")) != 0) {
ub_ctx_delete(res->ctx);
free(res);
-   log_warnx("error setting use-syslog: yes: %s",
+   log_warnx("error setting use-syslog: no: %s",
ub_strerror(err));
return (NULL);
}
+   ub_ctx_debugout(res->ctx, NULL);
}
 
break;
diff --git unwind.8 unwind.8
index f1c8c5cc827..8b784a1399a 100644
--- unwind.8
+++ unwind.8
@@ -92,6 +92,8 @@ Produce more verbose output.
 Multiple
 .Fl v
 options increase the verbosity.
+Debug output from libunbound is only available when logging to
+.Em stderr .
 .El
 .Sh FILES
 .Bl -tag -width "/var/db/unwind.keyXXX" -compact



-- 
I'm not entirely sure you are real.