Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread Stas Bekman
David Wheeler wrote: On Oct 19, 2004, at 5:22 AM, Stas Bekman wrote: Is it because you can't really do redirects on real POST requests? The body will get lost, isn't it? No, we do them all the time in Bricolage. In which case, can you please review Boris' patch and commit it if you think it's go

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread David Wheeler
On Oct 19, 2004, at 5:22 AM, Stas Bekman wrote: Is it because you can't really do redirects on real POST requests? The body will get lost, isn't it? No, we do them all the time in Bricolage. Regards, David

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread Boris Zentner
Hi, Am Dienstag 19 Oktober 2004 14:22 schrieb Stas Bekman: > Is it because you can't really do redirects on real POST requests? The > body will get lost, isn't it? But you reach the page, where the redirect points you to. -- Boris

t/htdocs/php/* licensing

2004-10-19 Thread Joe Orton
I just noticed that t/htdocs/php/regression* look like they are copies of files in the PHP source tree, yet have no associated license or copyright notices attached: http://cvs.apache.org/viewcvs.cgi/httpd-test/perl-framework/t/htdocs/php/regression2.php?rev=1.1.1.1&view=markup vs http://cvs.p

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-10-19 Thread Geoffrey Young
David Wheeler wrote: > On Oct 18, 2004, at 5:06 PM, [EMAIL PROTECTED] wrote: > >> add new test_config make target, equivalent to t/TEST -conf, >> and make it a prerequisite for the cmodules make target. now >> you can 'make cmodules' to build the things in c-modules/ >> without running

Re: outdated docs ( testing.html )

2004-10-19 Thread Stas Bekman
Boris Zentner wrote: Hi, while browsing http://perl.apache.org/docs/general/testing/testing.html, I discovered that the page describe the have function. But the Changelog of A::T says the have function is removed in falvor of need. it wasn't removed, it was replaced by need. and the original beha

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread Stas Bekman
David Wheeler wrote: On Oct 18, 2004, at 4:52 PM, Boris Zentner wrote: No, in that case I return $RedirectOK. I think that at least the return 0 if $request->method eq 'POST'; line is wrong, since I clearly have no chance to redirect a post request. I just left it that way because that the way i

outdated docs ( testing.html )

2004-10-19 Thread Boris Zentner
Hi, while browsing http://perl.apache.org/docs/general/testing/testing.html, I discovered that the page describe the have function. But the Changelog of A::T says the have function is removed in falvor of need. -- Boris

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread David Wheeler
On Oct 18, 2004, at 4:52 PM, Boris Zentner wrote: No, in that case I return $RedirectOK. I think that at least the return 0 if $request->method eq 'POST'; line is wrong, since I clearly have no chance to redirect a post request. I just left it that way because that the way it was when I started

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-10-19 Thread David Wheeler
On Oct 18, 2004, at 5:06 PM, [EMAIL PROTECTED] wrote: add new test_config make target, equivalent to t/TEST -conf, and make it a prerequisite for the cmodules make target. now you can 'make cmodules' to build the things in c-modules/ without running t/TEST -conf first. Uh, what? Can you te