On Jul 30, 2004, at 6:30 AM, Boris Zentner wrote:
So I think if LWP is used, instead of passing requests_redirectable to
LWP,
the 1 should be changed to [ qw/GET POST HEAD/ ] or propably more.
This patch
passwd all my tests.
Yes, of course you're right. It has just been so long since I looked at
[EMAIL PROTECTED] wrote:
theory 2004/07/30 19:43:33
+ # Always allow redirection.
+ my $redir = have_lwp ? [qw(GET HEAD POST)] : 1;
+ Apache::TestRequest::user_agent(reset = 1,
+ requests_redirectable = $redir);
Using have_ macros for non-plan()
Using have_ macros for non-plan() usage should be avoided, since it
populates the SKIP messages array and if later the test is skipped, for
a different reason it'll misleadingly tell the user that LWP was also a
requirement for that test (which quite possibly could be what we want).
We need
Geoffrey Young wrote:
Using have_ macros for non-plan() usage should be avoided, since it
populates the SKIP messages array and if later the test is skipped, for
a different reason it'll misleadingly tell the user that LWP was also a
requirement for that test (which quite possibly could be what we
On Jul 31, 2004, at 1:14 AM, Stas Bekman wrote:
so, have_foo is intuitive to be used anywhere in the code, and plan
now will look like:
plan tests = 5, need_lwp, need_cgi, need_php;
I like this, but isn't it putting the onus of change on module owners
and introducing the likelihood of
David Wheeler wrote:
On Jul 31, 2004, at 1:14 AM, Stas Bekman wrote:
so, have_foo is intuitive to be used anywhere in the code, and plan
now will look like:
plan tests = 5, need_lwp, need_cgi, need_php;
I like this, but isn't it putting the onus of change on module owners
and introducing the
