Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2004-04-28 Thread Stas Bekman
[EMAIL PROTECTED] wrote: geoff 2004/04/28 07:55:42 Modified:perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm Log: prevent 'Empty compile time value given to use lib' warnings Revision ChangesPath 1.88 +1 -0

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2004-04-28 Thread Geoffrey Young
I don't understand why did you have this problem (what did you have in @INC?), but I think that this just works around the problem. It's better to go up to where $self-{inc} is getting set and not let invalid values in, so if you use $self-{inc} you won't have to workaround again. I was

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-18 Thread Doug MacEachern
i don't feel strongly enough either way to debate further. i'll leave the decision to you stas.

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-18 Thread Stas Bekman
Doug MacEachern wrote: i don't feel strongly enough either way to debate further. i'll leave the decision to you stas. neither do I, so I'm just leaving the way it's ($class, $self). _ Stas Bekman JAm_pH --

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-17 Thread Stas Bekman
Doug MacEachern wrote: On Sun, 16 Sep 2001, Stas wrote: and what's the user of $class? When you can access it via __PACKAGE__ and you don't really need it anyway. __PACKAGE__ is not helpful if one day a test .pm wants to inherit APACHE_TEST_CONFIGURE from another class. most of the

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-16 Thread Stas
Doug MacEachern wrote: On Sun, 16 Sep 2001, Stas wrote: Hmm, we don't want to pass the package name to the package itself why not? because we know the package name anyway inside that package. :) this fixes it, so we can write: sub APACHE_TEST_CONFIG { my $self = shift; this seems fine

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-15 Thread Stas
[EMAIL PROTECTED] wrote: dougm 01/09/15 12:29:30 Modified:perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm Log: APACHE_TEST_CONFIGURE needs the Apache::TestConfig object Hmm, we don't want to pass the package name to the package itself, this fixes it, so we can write: sub

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-15 Thread Doug MacEachern
On Sun, 16 Sep 2001, Stas wrote: Hmm, we don't want to pass the package name to the package itself why not? this fixes it, so we can write: sub APACHE_TEST_CONFIG { my $self = shift; this seems fine to me: my($class, $config) = @_; -eval {