Re: [th-users] TagsPlugin and quoting (ab)use

2011-09-26 Thread Itamar O
On Sat, Sep 24, 2011 at 11:32 PM, Steffen Hoffmann hoff...@web.de wrote:

 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1

 Dear fellow developers,

 as I've been spending some time with the TagsPlugin source lately, I've
 been stumbling over the rather strange habit of quoting that it does.

 It is not required in the TagsQuery input field, but is getting there,
 i.e. if you follow tags links that look like
  `http://localhost:8000/sandbox/tags/%27Test%27`

 Despite of the handler for '/tags' there is no such thing like a Trac
 resource 'tags'. This is making all sorts of things more complicated.
 Consider URL construction with the Href class from trac.web.href, if
 you'd like to append some query attributes. It seems impossible right now.

 Anyone able to explain the history and reasons behind this situation?
 Would dropping the quoting in favor of something like
  `http://localhost:8000/sandbox/tags/Test?realms=wikiformat=table`
 do any harm?


This looks great for specific tags, but the query syntax supports richer
queries, e.g:
`http://localhost:8000/sandbox/tags?q=tags1+-tag2realms=wikiformat=table`http://localhost:8000/sandbox/tags/Test?realms=wikiformat=table`
Nonetheless, the example I have just specified has no need for quoting,
so I'm still not sure why the quoting exists, and see no good reason to
stick with it.



 I'd like to rather fix this than hack around it to resolve other, even
 related issues. Advise? Suggestions? Thoughts?

 Sincerely.

 Steffen Hoffmann
 (hasienda)
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1.4.10 (GNU/Linux)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

 iEYEARECAAYFAk5+PlcACgkQ31DJeiZFuHdMLQCgl4RADroNzR1oRljB89SmdBFD
 4PkAoL8w5f/SFnnen4YBCYJv2HE95mzX
 =GrHM
 -END PGP SIGNATURE-
 ___
 th-users mailing list
 th-users@lists.trac-hacks.org
 https://lists.trac-hacks.org/mailman/listinfo/th-users

___
th-users mailing list
th-users@lists.trac-hacks.org
https://lists.trac-hacks.org/mailman/listinfo/th-users


[th-users] TagsPlugin and quoting (ab)use

2011-09-24 Thread Steffen Hoffmann
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear fellow developers,

as I've been spending some time with the TagsPlugin source lately, I've
been stumbling over the rather strange habit of quoting that it does.

It is not required in the TagsQuery input field, but is getting there,
i.e. if you follow tags links that look like
 `http://localhost:8000/sandbox/tags/%27Test%27`

Despite of the handler for '/tags' there is no such thing like a Trac
resource 'tags'. This is making all sorts of things more complicated.
Consider URL construction with the Href class from trac.web.href, if
you'd like to append some query attributes. It seems impossible right now.

Anyone able to explain the history and reasons behind this situation?
Would dropping the quoting in favor of something like
 `http://localhost:8000/sandbox/tags/Test?realms=wikiformat=table`
do any harm?

I'd like to rather fix this than hack around it to resolve other, even
related issues. Advise? Suggestions? Thoughts?

Sincerely.

Steffen Hoffmann
(hasienda)
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5+PlcACgkQ31DJeiZFuHdMLQCgl4RADroNzR1oRljB89SmdBFD
4PkAoL8w5f/SFnnen4YBCYJv2HE95mzX
=GrHM
-END PGP SIGNATURE-
___
th-users mailing list
th-users@lists.trac-hacks.org
https://lists.trac-hacks.org/mailman/listinfo/th-users