Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Benedikt Hallinger
Hi there, i performed a git bisect (the very first in my lifetime, and that is really a nice and easy tool to search such things!!!). The commits at and before c7d41d9 compiled the cave sucessfully 10 of 10 times. 1c1fcf14e4eaf6e0bb89da513702ad9b89204ed8 is the first bad commit commit

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Martin Sluka via Therion
I use BBEdit on MacOSX and it has all features you mentioned. Martin > 14. 10. 2020 v 21:17, Tarquin Wilton-Jones via Therion : > > On 14/10/2020 20:08, Martin Sluka via Therion wrote: >> What about multifile search for”P]” in text files? It is quite strange >> combination of characters and

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Benedikt Hallinger
I just made a new issue ticket: https://github.com/therion/therion/issues/278 Am 2020-10-14 22:53, schrieb Benedikt Hallinger: Hi there, i performed a git bisect (the very first in my lifetime, and that is really a nice and easy tool to search such things!!!). The commits at and before

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Tarquin Wilton-Jones via Therion
> I think that the problem is caused by this line: > > rv.prjname = thcs_get_label(params).c_str(); > > because rv.prjname now contains a pointer to a temporary (and already > destroyed) string. Bravo on the speedy bug hunting! > With every run the string changes Heart sank as soon as I read

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Benedikt Hallinger
OK, now i got something. Guess what - one of about 5 compiles runs trough. This leads me to think that there is a race condition or something else somewhere, overwriting memory of the to-be-checked string. I'm pretty sure now that this is not a problem with the dataset per se, but some memory

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Benedikt Hallinger
Hello all, thanks for all the hints. What about multifile search for”P]” in text files? It is quite strange combination of characters and they are part of ASCII set. I had that in mind, but i don't think its the problem here. If it would, 5.5.1 should fail too... What about multifile search

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Wookey
On 2020-10-14 22:05 +0200, Benedikt Hallinger wrote: > OK, now i got something. > > Guess what - one of about 5 compiles runs trough. > This leads me to think that there is a race condition or something else > somewhere, overwriting memory of the to-be-checked string. > I'm pretty sure now that

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Benedikt Hallinger
I sent Martin a dataset to investigate. Hopefully he can spot something... Am 2020-10-14 21:40, schrieb Benedikt Hallinger: Hello all, thanks for all the hints. What about multifile search for”P]” in text files? It is quite strange combination of characters and they are part of ASCII set. I

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Matěj Plch
Hi, I think that the problem is caused by this line: rv.prjname = thcs_get_label(params).c_str(); because rv.prjname now contains a pointer to a temporary (and already destroyed) string. st 14. 10. 2020 v 23:04 odesílatel Benedikt Hallinger napsal: > > I just made a new issue ticket: >

[Therion] Survex (loop closure) related fixes

2020-10-14 Thread Tarquin Wilton-Jones via Therion
Hi folks, Stacho fixed these "when using Survex loop closure" bugs in yesterday's development release: https://github.com/therion/therion/issues/269 Therion miscalculates fixes in multiple centreline blocks when using Survex loop closure https://github.com/therion/therion/issues/270 Therion

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Benedikt Hallinger
I tried to compile the model of the Hirlatz cave with it and it looks good, from a big picture view. The passages shifted sometimes slightly, as expected. When trying to compile a specific plan map view PDF i get an error about UTF8. The compile runs fine with release-therion 5.5.1, however!

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Benedikt Hallinger
I experimented a little bit more. In the thconfig file I set some header data. statistics explo off statistics topo off statistics carto off statistics copyright all If i comment out the line #statistics carto off the compilation works

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Benedikt Hallinger
Hey Martin, thanks for responding. The exact same dataset compiles well with 5.5.1. As far as i know, no special characters are used here. As its rather huge, and i have no idea how to reduce the problem. It surely must be somewhere in the .th2 files "author", since that is probably the only

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Martin Budaj
On Wed, Oct 14, 2020 at 10:38 AM Benedikt Hallinger wrote: > When trying to compile a specific plan map view PDF i get an error about > UTF8. The compile runs fine with release-therion 5.5.1, however! > (i don't know if this is related) > Hi, there was no change in the processing of utf-8

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Tarquin Wilton-Jones via Therion
> I probably need to wade trough the data manually. QA folks start grinning. Generic instructions below: Take a copy of your dataset. Reproduce the problem. Comment out any joins. Recompile. Delete half the "input" statements, and their "equate". Recompile. Repeat until the problem disappears.

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Martin Sluka via Therion
What about multifile search for”P]” in text files? It is quite strange combination of characters and they are part of ASCII set. Martin Odesláno z iPhonu 14. 10. 2020 v 20:55, Tarquin Wilton-Jones via Therion : >> I probably need to wade trough the data manually. > > QA folks start

Re: [Therion] Survex (loop closure) related fixes

2020-10-14 Thread Tarquin Wilton-Jones via Therion
On 14/10/2020 20:08, Martin Sluka via Therion wrote: > What about multifile search for”P]” in text files? It is quite strange > combination of characters and they are part of ASCII set. If you have an editor that is working in the same character set as Therion, that could work. Definitely worth