Re: [Thunar-dev] Patch for adding emblem support to thunarx master

2009-12-08 Thread Benedikt Meurer
On Dec 7, 2009, at 17:25 , Adam Plumb wrote: Thanks for your suggestions with the new functions. I've updated my patch (and the bugzilla ticket) with the new functionality. I also changed the behavior of the add_emblem function to not allow adding an emblem that is already present.

Re: [Thunar-dev] Patch for adding emblem support to thunarx master

2009-12-07 Thread Adam Plumb
Thanks for your suggestion. I've modified the patch accordingly and filed a request on bugzilla at: http://bugzilla.xfce.org/show_bug.cgi?id=6055. Adam On Mon, Dec 7, 2009 at 2:11 AM, Brian J. Tarricone bj...@cornell.eduwrote: One little thing because it's an obvious problem: gchar

Re: [Thunar-dev] Patch for adding emblem support to thunarx master

2009-12-07 Thread Benedikt Meurer
On Dec 7, 2009, at 08:11 , Brian J. Tarricone wrote: One little thing because it's an obvious problem: gchar *(*get_mime_type) (ThunarxFileInfo *file_info); gboolean (*has_mime_type) (ThunarxFileInfo *file_info, const gchar

Re: [Thunar-dev] Patch for adding emblem support to thunarx master

2009-12-07 Thread Adam Plumb
Thanks for your suggestions with the new functions. I've updated my patch (and the bugzilla ticket) with the new functionality. I also changed the behavior of the add_emblem function to not allow adding an emblem that is already present. Does this seem like the correct behavior? Adam On Mon,

[Thunar-dev] Patch for adding emblem support to thunarx master

2009-12-06 Thread Adam Plumb
Hi all, this is my first attempt at writing a patch for Thunar, and I'm also somewhat new to C, so please excuse any mistakes I may have made. Also, this email is a dupe because I sent a previous one with a test extension that was too large. I've written a patch that adds emblem support to

Re: [Thunar-dev] Patch for adding emblem support to thunarx master

2009-12-06 Thread Yves-Alexis Perez
On dim., 2009-12-06 at 16:33 -0500, Adam Plumb wrote: The patch file is attached. I can also attach my test extension that demonstrates the functionality if anyone is interested. I'd appreciate any feedback on my work, and hopefully this will get accepted into the thunar master branch.

Re: [Thunar-dev] Patch for adding emblem support to thunarx master

2009-12-06 Thread Brian J. Tarricone
One little thing because it's an obvious problem: gchar *(*get_mime_type) (ThunarxFileInfo *file_info); gboolean (*has_mime_type) (ThunarxFileInfo *file_info, const gchar *mime_type); - + void (*set_emblem)