Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-30 Thread Stephan Hradek
I wanted to implement some of the suggested changes and do a new pull request with single files, but I'm too stupid for git. The fork I did on github is there and I don't want to delete it in order to see what you commented. I can't fork again. Github is not creating anythin, I guess, because

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-30 Thread Jeremy Ruston
Hi Stephan I'm really sorry, I hope someone else can jump in here; I'm not much of a git expert myself, and probably the worst person to try to teach other people --- especially since I'm struggling to document TW5 right now. Would you rather I taught you how to use git, or that I used my time to

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-30 Thread Eric Shulman
On Saturday, November 30, 2013 9:25:09 AM UTC-8, Stephan Hradek wrote: The fork I did on github is there and I don't want to delete it in order to see what you commented. I can't fork again. Github is not creating anythin, I guess, because I already forked. I cloned again here, but I seem

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-30 Thread Stephan Hradek
I think I solved it http://stackoverflow.com/questions/9538320/abandoning-git-commits-on-github-for-rejected-pull-requests helped. I resetted to just before my first commit. Then I updated to the most recent version. I think I'm done with the first hurdle. -- You received this message

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-29 Thread Stephan Hradek
Hi Jeremy, Am Freitag, 29. November 2013 08:39:05 UTC+1 schrieb Jeremy Ruston: Tiddler names are not unique enough. All it takes is for a tiddler to be displayed twice, which could happen with a hover-preview of a tiddler. But it's the same tiddler so the same radio buttons? Anyhow… Could

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-29 Thread Stephan Hradek
Am Donnerstag, 28. November 2013 15:41:43 UTC+1 schrieb Jeremy Ruston: Hi Stephan Good stuff. I'd encourage you to get up and running on GitHub so that you can send pull requests. Just did so - not sure whether I did it right. -- You received this message because you are subscribed to

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-29 Thread Jeremy Ruston
Just did so - not sure whether I did it right. Great, I'll add some comments there after replying to your message here earlier today, Best wishes Jeremy -- Jeremy Ruston mailto:jeremy.rus...@gmail.com -- You received this message because you are subscribed to the Google Groups

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-29 Thread Jeremy Ruston
On Fri, Nov 29, 2013 at 8:43 AM, Stephan Hradek stephan.hra...@gmail.comwrote: Hi Jeremy, Am Freitag, 29. November 2013 08:39:05 UTC+1 schrieb Jeremy Ruston: Tiddler names are not unique enough. All it takes is for a tiddler to be displayed twice, which could happen with a hover-preview of

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-29 Thread Stephan Hradek
Hi Jeremy Am Samstag, 30. November 2013 00:05:59 UTC+1 schrieb Jeremy Ruston: But wouldn't that mean that if I've got two sets of radio buttons displayed as part of two separate renderings of the same tiddler, then the browser would enforce a restriction such that only one radio button is

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-29 Thread Jeremy Ruston
No, just include the wiki.setField method in your pull request. Too late :( It will seem harsh but if I've learned anything about accepting contributions its that I must adopt the same standards as I would for my own work. I can't accept anything that I don't agree with. I try to be open

[twdev] [TW5] Radiobutton widget to set fields

2013-11-28 Thread Stephan Hradek
I just created a widget by ripping the checkbox widget apart ;) Usage is like so: * $radio field=myField value=1one/$radio * $radio field=myField value=2two/$radio * $radio field=myField value=3three/$radio This would set the field myField of the current tiddler to either 1, 2 or 3. You can

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-28 Thread Jeremy Ruston
Hi Stephan Good stuff. I'd encourage you to get up and running on GitHub so that you can send pull requests. One line did jump out: this.radioField = this.getAttribute(field).replace(/^(?=(?:[^!]|![^!])+$)/, this.getVariable(currentTiddler)+!!); It looks like you're doing this to convert the

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-28 Thread Stephan Hradek
Am Donnerstag, 28. November 2013 15:41:43 UTC+1 schrieb Jeremy Ruston: Hi Stephan Good stuff. I'd encourage you to get up and running on GitHub so that you can send pull requests. One line did jump out: this.radioField = this.getAttribute(field).replace(/^(?=(?:[^!]|![^!])+$)/,

Re: [twdev] [TW5] Radiobutton widget to set fields

2013-11-28 Thread Stephan Hradek
P.S.: I'd also like to give the radiobuttons the ability to handle tags like fields. I think this might be useful. Example: $radio tag=Class: value=AClass A/$radio $radio tag=Class: value=BClass B/$radio $radio tag=Class: value=CClass C/$radio This would delete all Class:\S* or