[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Simon Huber
sure, it's just testing! > If that's you just testing, that's fine. Otherwise you (the middle man) > are stealing a click from me (user) targeting YT itself -- in my view, > naughty ;) > > On Tuesday, January 16, 2018 at 9:42:01 AM UTC-6, Simon Huber wrote: >> >> Ah but... trying to go fullsc

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread coda coder
If that's you just testing, that's fine. Otherwise you (the middle man) are stealing a click from me (user) targeting YT itself -- in my view, naughty ;) On Tuesday, January 16, 2018 at 9:42:01 AM UTC-6, Simon Huber wrote: > > Ah but... trying to go fullscreen on the yt video fails -- the video

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Simon Huber
> > Ah but... trying to go fullscreen on the yt video fails -- the video > disappears. > > that's what it should do, as in the stylesheet there's .tw5-burning-tree .tc-tiddler-frame iframe { display: none; } ... to see if it happens with yt fullscreen, too -- You received this message because

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Simon Huber
that's good news! maybe as Jeremy said, css support is not far away. thanks for trying it out @coda coder, @Jeremy I've tried different approaches now and it can be done better than the first fast tries but it's a bit a mess and I can't get my head around it, too. not giving up on this, but eno

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread coda coder
Ah but... trying to go fullscreen on the yt video fails -- the video disappears. On Tuesday, January 16, 2018 at 9:31:42 AM UTC-6, coda coder wrote: > > Tried FF on Win10 too. Same. > > However (brace yourself) it works on FF 59.0a1, Win7 > > Can't try Win10 (don't have FF 59). > > On Tuesday, J

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread coda coder
Tried FF on Win10 too. Same. However (brace yourself) it works on FF 59.0a1, Win7 Can't try Win10 (don't have FF 59). On Tuesday, January 16, 2018 at 9:26:05 AM UTC-6, coda coder wrote: > > No, sorry. Same as before. > > On Tuesday, January 16, 2018 at 8:09:11 AM UTC-6, Simon Huber wrote: >> >>

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread coda coder
No, sorry. Same as before. On Tuesday, January 16, 2018 at 8:09:11 AM UTC-6, Simon Huber wrote: > > thanks @coda coder, > > that's bad news, I really want this :D > > I changed something I should have done earlier, if you want to give it > another try > > I'll investigate further, maybe i get thi

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Simon Huber
now i tried it on firefox, too. there it behaves as you report @coda coder works for me on chromium -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikid

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Simon Huber
thanks @coda coder, that's bad news, I really want this :D I changed something I should have done earlier, if you want to give it another try I'll investigate further, maybe i get this working, maybe not thanks for your help, Simon Am Dienstag, 16. Januar 2018 14:55:23 UTC+1 schrieb coda code

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread coda coder
Simon, I'm assuming your class addition to the body element should be toggling as I toggle F11? If so, it's not working here. Your class "tw5-burning-tree" once applied, is never removed. Your console message always says "not fullscreen" regardless of the actual state. Also, your class is ne

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Simon Huber
@Jeremy, I don't want to bother you too much with this, I've just put something together that works here: http://tw5fullscreen.tiddlyspot.com it prevents the F11 key's default event so that we're able to detect the key again when in fullscreen mode, then requests fullscreen and toggles the cl

Re: [twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Simon Huber
> > and it does what I expect from this, it adds the class to the body if > fullscreen. > > could this be implemented correctly in the core? > > > A change along those lines wouldn’t cover the situation where the user > uses a browser control like the F11 key to enter full screen mode. > it's t

Re: [twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Simon Huber
thank you, Jeremy! I'm going to give it a try, when I find a solution I'll make the pull request all the best, Simon Am Dienstag, 16. Januar 2018 09:32:29 UTC+1 schrieb Jeremy Ruston: > > Hi Simon > > and it does what I expect from this, it adds the class to the body if > fullscreen. > > could

Re: [twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Jeremy Ruston
Hi Simon > and it does what I expect from this, it adds the class to the body if > fullscreen. > > could this be implemented correctly in the core? A change along those lines wouldn’t cover the situation where the user uses a browser control like the F11 key to enter full screen mode. It appe

[twdev] Re: [TW5][REQUEST] window fullscreen - applying CLASS on

2018-01-16 Thread Simon Huber
In the saver-handler.js I just added if( window.innerHeight == screen.height) { // browser is fullscreen $tw.utils.toggleClass(document.body,"tc-fullscreen",true); } and it does what I expect from this, it adds the class to the body if fullscreen. could this be implemented correctly in