Re: [twdev] Re: rudimentary find-on-page support for TD

[Simon Huber]

it's pretty slow with many matches ...

Here's a second link to play around with highlight-all-found-words 
> functionality
>
> http://find-on-page-test2.tiddlyspot.com/
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/bde941cd-aba4-48f6-98ab-9208dce00400%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Re: rudimentary find-on-page support for TD

[Simon Huber]

Here's a second link to play around with highlight-all-found-words 
functionality

http://find-on-page-test2.tiddlyspot.com/


-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/a54c3fd1-c00f-4c79-b1d4-e0052799a4ae%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Re: rudimentary find-on-page support for TD

[@TiddlyTweeter]

Simon Huber wrote:
>
> ... first I'd like to have the functionality working for TiddlyDesktop
>

Not that I can help but getting it optimal for TD first sounds right as 
that is where we are most deficient. IF, after that, it can be generalised, 
so much the better. 

Thoughts
Josiah

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/9e82d352-01b9-457a-a2f7-97fc692196d0%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Re: rudimentary find-on-page support for TD

[Simon Huber]

I'm making good progress with this, now I can highlight all matches through 
a surrounding span which gets removed at every new search.

A global handler, like the keyboardmanager, does the handling, an 
action-widget provides access to the search functionality


The tiddlyspot page isn't updated, I don't remember the pass anymore. I 
don't know, shall I make this a PR so that we can work together?

If so, what should this be, a tiddlydesktop extension?

I don't know if I can make it work crossbrowser, some information I found 
suggests it's possible.
One could get the bounding rects from matches, which could be useful to use 
elsewhere, so it could be extended in its use.

Anyway, first I'd like to have the functionality working for TiddlyDesktop

best wishes,
Simon

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/2fcba27b-40e1-4123-8877-b26ccd7681f5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Re: rudimentary find-on-page support for TD

[Simon Huber]

>
> Just to clarify, I'm all in favour of having find-in-page in 
> TiddlyDesktop, and welcome any help. I think Simon's approach is a 
> promising one: to make a find-in-page that works in a standalone TW. The 
> other approach is to extend TiddlyDesktop itself with the functionality.
>

That's cool, thanks Jeremy!

Extending TiddlyDesktop itself is cumbersome I found. On the nw.js repo 
there are some questions about it, but it doesn't seem to be clear if it 
works using webview or how to do it ... so I thought maybe it's better 
doing it this way ...

best wishes back
 

>
> Best wishes
>
> Jeremy
>
> --
> Jeremy Ruston
> jer...@jermolene.com 
> https://jermolene.com
>
> On 27 Feb 2019, at 16:23, Simon Huber  > wrote:
>
> Simon Huber wrote:
>>>
>>> I've created this little demo here: 
>>> http://find-on-page-test.tiddlyspot.com/
>>>
>>> It allows to find words on the page using a very simple action-widget
>>>
>>>  what I've noticed is that matches on tags are found but the 
>>> selection isn't visible.
>>>
>>  
>> Right. I'm doubtful its workable without visual feedback. I tried. I 
>> failed.
>>
>> Josiah
>>
>
> I have a solution for that, it's just not updated online. The problem is 
> that elements that are draggable (that have the draggable attr. ="true") 
> cannot be found.
>
> My solution is to change the TagTemplate and put a condition inside that  
> shows tags without dragFilter (which removes the draggable attr.) when the 
> search panel is open.
> That would probably work best when it would be a popup, so the condition 
> would be: when that popup state tiddler is present, no dragFilter for tags.
> problem: we cannot create popups using keyboard shortcuts, which would be 
> very useful here.
> solution: I could add my action-popup widget here
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikide...@googlegroups.com .
> To post to this group, send email to tiddly...@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/tiddlywikidev.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/04c03038-d9bb-4a0c-a0a1-b1b2e165a402%40googlegroups.com
>  
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/c4a9a26a-b4e1-4262-ad6a-f347f5d31027%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [twdev] Re: rudimentary find-on-page support for TD

[Jeremy Ruston]

Just to clarify, I'm all in favour of having find-in-page in TiddlyDesktop, and 
welcome any help. I think Simon's approach is a promising one: to make a 
find-in-page that works in a standalone TW. The other approach is to extend 
TiddlyDesktop itself with the functionality.

Best wishes

Jeremy

--
Jeremy Ruston
jer...@jermolene.com
https://jermolene.com

> On 27 Feb 2019, at 16:23, Simon Huber  wrote:
> 
>>> Simon Huber wrote:
>>> I've created this little demo here: http://find-on-page-test.tiddlyspot.com/
>>> 
>>> It allows to find words on the page using a very simple action-widget
>>> 
>>>  what I've noticed is that matches on tags are found but the selection 
>>> isn't visible.
>>  
>> Right. I'm doubtful its workable without visual feedback. I tried. I failed.
>> 
>> Josiah
> 
> I have a solution for that, it's just not updated online. The problem is that 
> elements that are draggable (that have the draggable attr. ="true") cannot be 
> found.
> 
> My solution is to change the TagTemplate and put a condition inside that  
> shows tags without dragFilter (which removes the draggable attr.) when the 
> search panel is open.
> That would probably work best when it would be a popup, so the condition 
> would be: when that popup state tiddler is present, no dragFilter for tags.
> problem: we cannot create popups using keyboard shortcuts, which would be 
> very useful here.
> solution: I could add my action-popup widget here
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikidev+unsubscr...@googlegroups.com.
> To post to this group, send email to tiddlywikidev@googlegroups.com.
> Visit this group at https://groups.google.com/group/tiddlywikidev.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/04c03038-d9bb-4a0c-a0a1-b1b2e165a402%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/6156A910-2829-49AE-A29C-D02DE3AED45E%40gmail.com.
For more options, visit https://groups.google.com/d/optout.