Re: [Tigervnc-devel] [Tigervnc-commits] SF.net SVN: tigervnc:[4646] trunk/vncviewer

2011-08-25 Thread DRC
I never said the rest of the code was doing the right thing, either. I think you're missing my point. Instead of manually including config.h in every file that needs NLS, why not simply put add_definitions(-DENABLE_NLS=1) in CMakeLists.txt? Seems much less error prone. On Aug 25, 2011, at 1:57

Re: [Tigervnc-devel] [Tigervnc-commits] SF.net SVN: tigervnc:[4646] trunk/vncviewer

2011-08-24 Thread Peter Åstrand
Can you please explain this further? If you don't include config.h, then ENABLE_NLS won't be defined, meaning that gettext.h will use dummy translation routines. Rgds, Peter On 8/23/11 7:04 AM, astr...@users.sourceforge.net wrote: Revision: 4646

Re: [Tigervnc-devel] [Tigervnc-commits] SF.net SVN: tigervnc:[4646] trunk/vncviewer

2011-08-24 Thread DRC
I think that such a critical #define really needs to be #defined on the command line. Manually #including it in every file that needs it is a recipe for errors-- in this case, silent ones. On 8/24/11 1:18 AM, Peter Åstrand wrote: Can you please explain this further? If you don't include

Re: [Tigervnc-devel] [Tigervnc-commits] SF.net SVN: tigervnc:[4646] trunk/vncviewer

2011-08-23 Thread DRC
Can you please explain this further? On 8/23/11 7:04 AM, astr...@users.sourceforge.net wrote: Revision: 4646 http://tigervnc.svn.sourceforge.net/tigervnc/?rev=4646view=rev Author: astrand Date: 2011-08-23 12:04:46 + (Tue, 23 Aug 2011) Log Message: --- Make sure