Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-18 Thread Adam Tkac
On Thu, Nov 11, 2010 at 10:51:46PM +0100, Martin Koegler wrote: Two general comments: Thanks for your comments, I've modified the patch and commited it as r4198. * This patch will probably break the windows build, as it adds an msg!=NULL assert without setting the variable on Windows. The

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-11 Thread Guillaume Destuynder
On 11/10/2010 10:24 PM, Martin Koegler wrote: The best thing would be to change the default value of cafile at the startup of the program to $HOME/ . The current implementation only allows fixed values as default. I hit a similar problem while there was only one security type parameter for

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-11 Thread Martin Koegler
Two general comments: * This patch will probably break the windows build, as it adds an msg!=NULL assert without setting the variable on Windows. The best solution would be to add the windows implementation too. * CSecurityTLS is only available, if tigervnc is built with GNUTLS. So it should