Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-29 Thread DRC
On 9/20/10 3:42 AM, Adam Tkac wrote: Which version of autoconf are you using? The version that ships with RHEL 4 (2.59). The attached patch seems to make things work properly. Question for Martin: Is the while(0) really necessary? I don't understand why the macro can't just be: #define

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-18 Thread DRC
On 9/18/10 4:48 AM, Martin Koegler wrote: Autoconf allows adding a argument list to a Macro defined by AC_DEFINE: | -- Macro: AC_DEFINE (VARIABLE, VALUE, [DESCRIPTION]) | -- Macro: AC_DEFINE (VARIABLE) | Define VARIABLE to VALUE (verbatim), by defining a C preprocessor | macro

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-16 Thread DRC
On 9/9/10 2:11 AM, Martin Koegler wrote: I can not imaging, how such errors can happen. This test only adds the following to config.h: | /* Is gnutls_set_global_errno present */ | #define gnutls_transport_set_global_errno(A) do { errno = (A); } while(0) | So any code not refering to

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-09 Thread Martin Koegler
On Wed, Sep 08, 2010 at 02:14:55AM -0500, DRC wrote: However, when I attempted to apply the patch to work around this, I got a worse build error: gcc4 -DHAVE_CONFIG_H -I. -I/home/drc/worksrc/tigervnc/common/os -I../.. -I/home/drc/worksrc/tigervnc/common -O3 -static-libgcc -fPIC -Wall -MT

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-08 Thread DRC
I have confirmed that RHEL 4 doesn't have the gnutls_transport_set_global_errno function: g++ -DHAVE_CONFIG_H -I. -I/home/drc/worksrc/tigervnc/common/rdr -I../.. -I/home/drc/worksrc/tigervnc/common -I/home/drc/worksrc/tigervnc/common/zlib -O3 -static-libgcc -fPIC -Wall -MT

Re: [Tigervnc-devel] [PATCH] Workaround for older gnutls

2010-09-03 Thread DRC
On 9/2/10 11:53 PM, Martin Koegler wrote: After checking, when gnutls_transport_set_global_errno was introduced, please decide yourself, if support for older versions is really necessary. I need to try building this stuff on RHEL 4 to make sure it all works on that platform. I'll try to get